qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Weiwei Li <liweiwei@iscas.ac.cn>
To: anup@brainfault.org, palmer@dabbelt.com,
	alistair.francis@wdc.com, bin.meng@windriver.com,
	qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com,
	Guo Ren <ren_guo@c-sky.com>
Subject: [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64
Date: Tue, 18 Jan 2022 09:17:07 +0800	[thread overview]
Message-ID: <20220118011711.7243-2-liweiwei@iscas.ac.cn> (raw)
In-Reply-To: <20220118011711.7243-1-liweiwei@iscas.ac.cn>

From: Guo Ren <ren_guo@c-sky.com>

Highest bits of PTE has been used for svpbmt, ref: [1], [2], so we
need to ignore them. They cannot be a part of ppn.

1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture
   4.4 Sv39: Page-Based 39-bit Virtual-Memory System
   4.5 Sv48: Page-Based 48-bit Virtual-Memory System

2: https://github.com/riscv/virtual-memory/blob/main/specs/663-Svpbmt-diff.pdf

Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Liu Zhiwei <zhiwei_liu@c-sky.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
 target/riscv/cpu_bits.h   | 7 +++++++
 target/riscv/cpu_helper.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
index 5a6d49aa64..282cd8eecd 100644
--- a/target/riscv/cpu_bits.h
+++ b/target/riscv/cpu_bits.h
@@ -490,6 +490,13 @@ typedef enum {
 /* Page table PPN shift amount */
 #define PTE_PPN_SHIFT       10
 
+/* Page table PPN mask */
+#if defined(TARGET_RISCV32)
+#define PTE_PPN_MASK        0xffffffffUL
+#elif defined(TARGET_RISCV64)
+#define PTE_PPN_MASK        0x3fffffffffffffULL
+#endif
+
 /* Leaf page shift amount */
 #define PGSHIFT             12
 
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 434a83e66a..26608ddf1c 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -619,7 +619,7 @@ restart:
             return TRANSLATE_FAIL;
         }
 
-        hwaddr ppn = pte >> PTE_PPN_SHIFT;
+        hwaddr ppn = (pte & PTE_PPN_MASK) >> PTE_PPN_SHIFT;
 
         if (!(pte & PTE_V)) {
             /* Invalid PTE */
-- 
2.17.1



  reply	other threads:[~2022-01-18  1:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18  1:17 [PATCH v5 0/5] support subsets of virtual memory extension Weiwei Li
2022-01-18  1:17 ` Weiwei Li [this message]
2022-01-18  3:30   ` [PATCH v5 1/5] target/riscv: Ignore reserved bits in PTE for RV64 Anup Patel
2022-01-18  4:51     ` Alistair Francis
2022-01-18 11:54       ` Guo Ren
2022-01-20 13:47       ` Guo Ren
2022-01-20 22:28         ` LIU Zhiwei
2022-01-21  1:50           ` Guo Ren
2022-01-21  2:08             ` LIU Zhiwei
2022-01-18  8:33     ` Guo Ren
2022-01-18  8:51       ` Anup Patel
2022-01-18 11:15         ` Guo Ren
2022-01-18 11:25           ` Anup Patel
2022-01-18 11:28           ` Anup Patel
2022-01-18 11:57             ` Guo Ren
2022-01-18 11:29           ` Weiwei Li
2022-01-19  3:14             ` LIU Zhiwei
2022-01-18  1:17 ` [PATCH v5 2/5] target/riscv: add PTE_A/PTE_D/PTE_U bits check for inner PTE Weiwei Li
2022-01-18  1:17 ` [PATCH v5 3/5] target/riscv: add support for svnapot extension Weiwei Li
2022-01-18  3:32   ` Anup Patel
2022-01-18  8:32     ` Weiwei Li
2022-01-18  1:17 ` [PATCH v5 4/5] target/riscv: add support for svinval extension Weiwei Li
2022-01-18  1:17 ` [PATCH v5 5/5] target/riscv: add support for svpbmt extension Weiwei Li
2022-01-18  3:35   ` Anup Patel
2022-01-18  8:33     ` Weiwei Li
2022-01-18  9:09     ` Weiwei Li
2022-01-18 11:04       ` Anup Patel
2022-01-18 11:21         ` Weiwei Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118011711.7243-2-liweiwei@iscas.ac.cn \
    --to=liweiwei@iscas.ac.cn \
    --cc=alistair.francis@wdc.com \
    --cc=anup@brainfault.org \
    --cc=bin.meng@windriver.com \
    --cc=lazyparser@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=ren_guo@c-sky.com \
    --cc=wangjunqiang@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).