* [PATCH v1] include: hw: remove ibex_plic.h
@ 2022-01-21 5:50 Alistair Francis
2022-01-21 6:15 ` Alistair Francis
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alistair Francis @ 2022-01-21 5:50 UTC (permalink / raw)
To: qemu-devel, qemu-riscv
Cc: bmeng.cn, palmer, alistair.francis, alistair23, wilfred.mallawa
From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
This patch removes the left-over/unused `ibex_plic.h` file. Previously
used by opentitan, which now follows the RISC-V standard and uses the
SiFivePlicState.
Fixes: 434e7e021 ("hw/intc: Remove the Ibex PLIC")
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
---
include/hw/intc/ibex_plic.h | 67 -------------------------------------
1 file changed, 67 deletions(-)
delete mode 100644 include/hw/intc/ibex_plic.h
diff --git a/include/hw/intc/ibex_plic.h b/include/hw/intc/ibex_plic.h
deleted file mode 100644
index d596436e06..0000000000
--- a/include/hw/intc/ibex_plic.h
+++ /dev/null
@@ -1,67 +0,0 @@
-/*
- * QEMU RISC-V lowRISC Ibex PLIC
- *
- * Copyright (c) 2020 Western Digital
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2 or later, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program. If not, see <http://www.gnu.org/licenses/>.
- */
-
-#ifndef HW_IBEX_PLIC_H
-#define HW_IBEX_PLIC_H
-
-#include "hw/sysbus.h"
-#include "qom/object.h"
-
-#define TYPE_IBEX_PLIC "ibex-plic"
-OBJECT_DECLARE_SIMPLE_TYPE(IbexPlicState, IBEX_PLIC)
-
-struct IbexPlicState {
- /*< private >*/
- SysBusDevice parent_obj;
-
- /*< public >*/
- MemoryRegion mmio;
-
- uint32_t *pending;
- uint32_t *hidden_pending;
- uint32_t *claimed;
- uint32_t *source;
- uint32_t *priority;
- uint32_t *enable;
- uint32_t threshold;
- uint32_t claim;
-
- /* config */
- uint32_t num_cpus;
- uint32_t num_sources;
-
- uint32_t pending_base;
- uint32_t pending_num;
-
- uint32_t source_base;
- uint32_t source_num;
-
- uint32_t priority_base;
- uint32_t priority_num;
-
- uint32_t enable_base;
- uint32_t enable_num;
-
- uint32_t threshold_base;
-
- uint32_t claim_base;
-
- qemu_irq *external_irqs;
-};
-
-#endif /* HW_IBEX_PLIC_H */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] include: hw: remove ibex_plic.h
2022-01-21 5:50 [PATCH v1] include: hw: remove ibex_plic.h Alistair Francis
@ 2022-01-21 6:15 ` Alistair Francis
2022-01-21 10:26 ` Philippe Mathieu-Daudé via
2022-01-23 23:28 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2022-01-21 6:15 UTC (permalink / raw)
To: Alistair Francis
Cc: open list:RISC-V, wilfred.mallawa,
qemu-devel@nongnu.org Developers, Palmer Dabbelt,
Alistair Francis, Bin Meng
On Fri, Jan 21, 2022 at 3:50 PM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> This patch removes the left-over/unused `ibex_plic.h` file. Previously
> used by opentitan, which now follows the RISC-V standard and uses the
> SiFivePlicState.
>
> Fixes: 434e7e021 ("hw/intc: Remove the Ibex PLIC")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> include/hw/intc/ibex_plic.h | 67 -------------------------------------
> 1 file changed, 67 deletions(-)
> delete mode 100644 include/hw/intc/ibex_plic.h
>
> diff --git a/include/hw/intc/ibex_plic.h b/include/hw/intc/ibex_plic.h
> deleted file mode 100644
> index d596436e06..0000000000
> --- a/include/hw/intc/ibex_plic.h
> +++ /dev/null
> @@ -1,67 +0,0 @@
> -/*
> - * QEMU RISC-V lowRISC Ibex PLIC
> - *
> - * Copyright (c) 2020 Western Digital
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms and conditions of the GNU General Public License,
> - * version 2 or later, as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> - * more details.
> - *
> - * You should have received a copy of the GNU General Public License along with
> - * this program. If not, see <http://www.gnu.org/licenses/>.
> - */
> -
> -#ifndef HW_IBEX_PLIC_H
> -#define HW_IBEX_PLIC_H
> -
> -#include "hw/sysbus.h"
> -#include "qom/object.h"
> -
> -#define TYPE_IBEX_PLIC "ibex-plic"
> -OBJECT_DECLARE_SIMPLE_TYPE(IbexPlicState, IBEX_PLIC)
> -
> -struct IbexPlicState {
> - /*< private >*/
> - SysBusDevice parent_obj;
> -
> - /*< public >*/
> - MemoryRegion mmio;
> -
> - uint32_t *pending;
> - uint32_t *hidden_pending;
> - uint32_t *claimed;
> - uint32_t *source;
> - uint32_t *priority;
> - uint32_t *enable;
> - uint32_t threshold;
> - uint32_t claim;
> -
> - /* config */
> - uint32_t num_cpus;
> - uint32_t num_sources;
> -
> - uint32_t pending_base;
> - uint32_t pending_num;
> -
> - uint32_t source_base;
> - uint32_t source_num;
> -
> - uint32_t priority_base;
> - uint32_t priority_num;
> -
> - uint32_t enable_base;
> - uint32_t enable_num;
> -
> - uint32_t threshold_base;
> -
> - uint32_t claim_base;
> -
> - qemu_irq *external_irqs;
> -};
> -
> -#endif /* HW_IBEX_PLIC_H */
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] include: hw: remove ibex_plic.h
2022-01-21 5:50 [PATCH v1] include: hw: remove ibex_plic.h Alistair Francis
2022-01-21 6:15 ` Alistair Francis
@ 2022-01-21 10:26 ` Philippe Mathieu-Daudé via
2022-01-23 23:28 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-21 10:26 UTC (permalink / raw)
To: Alistair Francis, qemu-devel, qemu-riscv
Cc: bmeng.cn, palmer, alistair.francis, alistair23, wilfred.mallawa
On 1/21/22 06:50, Alistair Francis wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> This patch removes the left-over/unused `ibex_plic.h` file. Previously
> used by opentitan, which now follows the RISC-V standard and uses the
> SiFivePlicState.
>
> Fixes: 434e7e021 ("hw/intc: Remove the Ibex PLIC")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> ---
> include/hw/intc/ibex_plic.h | 67 -------------------------------------
> 1 file changed, 67 deletions(-)
> delete mode 100644 include/hw/intc/ibex_plic.h
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] include: hw: remove ibex_plic.h
2022-01-21 5:50 [PATCH v1] include: hw: remove ibex_plic.h Alistair Francis
2022-01-21 6:15 ` Alistair Francis
2022-01-21 10:26 ` Philippe Mathieu-Daudé via
@ 2022-01-23 23:28 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2022-01-23 23:28 UTC (permalink / raw)
To: Alistair Francis
Cc: open list:RISC-V, wilfred.mallawa,
qemu-devel@nongnu.org Developers, Palmer Dabbelt,
Alistair Francis, Bin Meng
On Fri, Jan 21, 2022 at 3:50 PM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> This patch removes the left-over/unused `ibex_plic.h` file. Previously
> used by opentitan, which now follows the RISC-V standard and uses the
> SiFivePlicState.
>
> Fixes: 434e7e021 ("hw/intc: Remove the Ibex PLIC")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> include/hw/intc/ibex_plic.h | 67 -------------------------------------
> 1 file changed, 67 deletions(-)
> delete mode 100644 include/hw/intc/ibex_plic.h
>
> diff --git a/include/hw/intc/ibex_plic.h b/include/hw/intc/ibex_plic.h
> deleted file mode 100644
> index d596436e06..0000000000
> --- a/include/hw/intc/ibex_plic.h
> +++ /dev/null
> @@ -1,67 +0,0 @@
> -/*
> - * QEMU RISC-V lowRISC Ibex PLIC
> - *
> - * Copyright (c) 2020 Western Digital
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms and conditions of the GNU General Public License,
> - * version 2 or later, as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> - * more details.
> - *
> - * You should have received a copy of the GNU General Public License along with
> - * this program. If not, see <http://www.gnu.org/licenses/>.
> - */
> -
> -#ifndef HW_IBEX_PLIC_H
> -#define HW_IBEX_PLIC_H
> -
> -#include "hw/sysbus.h"
> -#include "qom/object.h"
> -
> -#define TYPE_IBEX_PLIC "ibex-plic"
> -OBJECT_DECLARE_SIMPLE_TYPE(IbexPlicState, IBEX_PLIC)
> -
> -struct IbexPlicState {
> - /*< private >*/
> - SysBusDevice parent_obj;
> -
> - /*< public >*/
> - MemoryRegion mmio;
> -
> - uint32_t *pending;
> - uint32_t *hidden_pending;
> - uint32_t *claimed;
> - uint32_t *source;
> - uint32_t *priority;
> - uint32_t *enable;
> - uint32_t threshold;
> - uint32_t claim;
> -
> - /* config */
> - uint32_t num_cpus;
> - uint32_t num_sources;
> -
> - uint32_t pending_base;
> - uint32_t pending_num;
> -
> - uint32_t source_base;
> - uint32_t source_num;
> -
> - uint32_t priority_base;
> - uint32_t priority_num;
> -
> - uint32_t enable_base;
> - uint32_t enable_num;
> -
> - uint32_t threshold_base;
> -
> - uint32_t claim_base;
> -
> - qemu_irq *external_irqs;
> -};
> -
> -#endif /* HW_IBEX_PLIC_H */
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-23 23:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-21 5:50 [PATCH v1] include: hw: remove ibex_plic.h Alistair Francis
2022-01-21 6:15 ` Alistair Francis
2022-01-21 10:26 ` Philippe Mathieu-Daudé via
2022-01-23 23:28 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).