* [PATCH] target/avr: Correct AVRCPUClass docstring
@ 2022-01-22 0:10 Philippe Mathieu-Daudé via
2022-01-24 8:14 ` Richard Henderson
2022-02-21 17:17 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-22 0:10 UTC (permalink / raw)
To: qemu-devel
Cc: Joaquin de Andres, Michael Rolnik, qemu-trivial,
Philippe Mathieu-Daudé
There is no 'vr' field in AVRCPUClass.
Likely a copy/paste typo from CRISCPUClass ;)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/avr/cpu-qom.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/avr/cpu-qom.h b/target/avr/cpu-qom.h
index 9fa6989c18..14e5b3ce72 100644
--- a/target/avr/cpu-qom.h
+++ b/target/avr/cpu-qom.h
@@ -33,7 +33,6 @@ OBJECT_DECLARE_TYPE(AVRCPU, AVRCPUClass,
* AVRCPUClass:
* @parent_realize: The parent class' realize handler.
* @parent_reset: The parent class' reset handler.
- * @vr: Version Register value.
*
* A AVR CPU model.
*/
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/avr: Correct AVRCPUClass docstring
2022-01-22 0:10 [PATCH] target/avr: Correct AVRCPUClass docstring Philippe Mathieu-Daudé via
@ 2022-01-24 8:14 ` Richard Henderson
2022-02-21 17:17 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-01-24 8:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Joaquin de Andres, Michael Rolnik
On 1/22/22 11:10 AM, Philippe Mathieu-Daudé via wrote:
> There is no 'vr' field in AVRCPUClass.
>
> Likely a copy/paste typo from CRISCPUClass ;)
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> target/avr/cpu-qom.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/avr: Correct AVRCPUClass docstring
2022-01-22 0:10 [PATCH] target/avr: Correct AVRCPUClass docstring Philippe Mathieu-Daudé via
2022-01-24 8:14 ` Richard Henderson
@ 2022-02-21 17:17 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2022-02-21 17:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Joaquin de Andres, Michael Rolnik
Le 22/01/2022 à 01:10, Philippe Mathieu-Daudé via a écrit :
> There is no 'vr' field in AVRCPUClass.
>
> Likely a copy/paste typo from CRISCPUClass ;)
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/avr/cpu-qom.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/avr/cpu-qom.h b/target/avr/cpu-qom.h
> index 9fa6989c18..14e5b3ce72 100644
> --- a/target/avr/cpu-qom.h
> +++ b/target/avr/cpu-qom.h
> @@ -33,7 +33,6 @@ OBJECT_DECLARE_TYPE(AVRCPU, AVRCPUClass,
> * AVRCPUClass:
> * @parent_realize: The parent class' realize handler.
> * @parent_reset: The parent class' reset handler.
> - * @vr: Version Register value.
> *
> * A AVR CPU model.
> */
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-21 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-22 0:10 [PATCH] target/avr: Correct AVRCPUClass docstring Philippe Mathieu-Daudé via
2022-01-24 8:14 ` Richard Henderson
2022-02-21 17:17 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).