* [PATCH] target/ppc: Put do_rfi under a TCG-only block
@ 2022-01-24 19:15 Fabiano Rosas
2022-01-24 23:10 ` Philippe Mathieu-Daudé via
2022-01-25 20:57 ` Daniel Henrique Barboza
0 siblings, 2 replies; 3+ messages in thread
From: Fabiano Rosas @ 2022-01-24 19:15 UTC (permalink / raw)
To: qemu-devel; +Cc: danielhb413, qemu-ppc, clg
The --disable-tcg build broke when do_rfi stopped being inlined.
Fixes: 62e79ef914 ("target/ppc: Remove static inline")
Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
target/ppc/excp_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index bc646c67a0..afdb6a8912 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -1155,7 +1155,6 @@ void helper_pminsn(CPUPPCState *env, powerpc_pm_insn_t insn)
(env->spr[SPR_PSSCR] & PSSCR_EC);
}
#endif /* defined(TARGET_PPC64) */
-#endif /* CONFIG_TCG */
static void do_rfi(CPUPPCState *env, target_ulong nip, target_ulong msr)
{
@@ -1188,7 +1187,6 @@ static void do_rfi(CPUPPCState *env, target_ulong nip, target_ulong msr)
check_tlb_flush(env, false);
}
-#ifdef CONFIG_TCG
void helper_rfi(CPUPPCState *env)
{
do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/ppc: Put do_rfi under a TCG-only block
2022-01-24 19:15 [PATCH] target/ppc: Put do_rfi under a TCG-only block Fabiano Rosas
@ 2022-01-24 23:10 ` Philippe Mathieu-Daudé via
2022-01-25 20:57 ` Daniel Henrique Barboza
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-24 23:10 UTC (permalink / raw)
To: Fabiano Rosas, qemu-devel; +Cc: danielhb413, qemu-ppc, clg
On 24/1/22 20:15, Fabiano Rosas wrote:
> The --disable-tcg build broke when do_rfi stopped being inlined.
>
> Fixes: 62e79ef914 ("target/ppc: Remove static inline")
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> target/ppc/excp_helper.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/ppc: Put do_rfi under a TCG-only block
2022-01-24 19:15 [PATCH] target/ppc: Put do_rfi under a TCG-only block Fabiano Rosas
2022-01-24 23:10 ` Philippe Mathieu-Daudé via
@ 2022-01-25 20:57 ` Daniel Henrique Barboza
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Henrique Barboza @ 2022-01-25 20:57 UTC (permalink / raw)
To: Fabiano Rosas, qemu-devel; +Cc: qemu-ppc, clg
On 1/24/22 16:15, Fabiano Rosas wrote:
> The --disable-tcg build broke when do_rfi stopped being inlined.
>
> Fixes: 62e79ef914 ("target/ppc: Remove static inline")
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> target/ppc/excp_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index bc646c67a0..afdb6a8912 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -1155,7 +1155,6 @@ void helper_pminsn(CPUPPCState *env, powerpc_pm_insn_t insn)
> (env->spr[SPR_PSSCR] & PSSCR_EC);
> }
> #endif /* defined(TARGET_PPC64) */
> -#endif /* CONFIG_TCG */
>
> static void do_rfi(CPUPPCState *env, target_ulong nip, target_ulong msr)
> {
> @@ -1188,7 +1187,6 @@ static void do_rfi(CPUPPCState *env, target_ulong nip, target_ulong msr)
> check_tlb_flush(env, false);
> }
>
> -#ifdef CONFIG_TCG
> void helper_rfi(CPUPPCState *env)
> {
> do_rfi(env, env->spr[SPR_SRR0], env->spr[SPR_SRR1] & 0xfffffffful);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-25 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-24 19:15 [PATCH] target/ppc: Put do_rfi under a TCG-only block Fabiano Rosas
2022-01-24 23:10 ` Philippe Mathieu-Daudé via
2022-01-25 20:57 ` Daniel Henrique Barboza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).