From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "David Edmondson" <david.edmondson@oracle.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Kashyap Chamarthy" <kchamart@redhat.com>
Subject: Re: [PATCH] docs: expand firmware descriptor to allow flash without NVRAM
Date: Tue, 25 Jan 2022 08:50:54 +0100 [thread overview]
Message-ID: <20220125075054.dnlnr4pliw3bio2k@sirius.home.kraxel.org> (raw)
In-Reply-To: <aa00dae7-e092-573a-a6ce-f7cf347f294c@amsat.org>
Hi,
> > { 'struct' : 'FirmwareMappingFlash',
> > - 'data' : { 'executable' : 'FirmwareFlashFile',
> > - 'nvram-template' : 'FirmwareFlashFile' } }
> > + 'data' : { 'mode': 'FirmwareFlashMode',
> > + 'executable' : 'FirmwareFlashFile',
> > + '*nvram-template' : 'FirmwareFlashFile' } }
I think for backward compatibility reasons we want 'mode' be optional,
with 'mode' = 'split' being assumed in case it is not present.
otherwise looks sane to me.
take care,
Gerd
next prev parent reply other threads:[~2022-01-25 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 15:34 [PATCH] docs: expand firmware descriptor to allow flash without NVRAM Daniel P. Berrangé
2022-01-22 9:07 ` Philippe Mathieu-Daudé via
2022-01-25 7:50 ` Gerd Hoffmann [this message]
2022-01-25 15:09 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125075054.dnlnr4pliw3bio2k@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=f4bug@amsat.org \
--cc=kchamart@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).