qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, michael.roth@amd.com, armbru@redhat.com,
	vsementsov@virtuozzo.com, jsnow@redhat.com, hreitz@redhat.com,
	kwolf@redhat.com, pbonzini@redhat.com
Subject: [PATCH v5 6/7] meson: document, why we don't generate trace events for tests/ and qga/
Date: Tue, 25 Jan 2022 22:56:54 +0100	[thread overview]
Message-ID: <20220125215655.3111881-7-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20220125215655.3111881-1-vsementsov@virtuozzo.com>

Making trace generation work for tests/ and qga/ would involve some
Meson hackery to ensure we generate the trace-events files before
trace-tool uses them. Since we don't actually support tracing there
anyway, we bypass that problem.

Let's add corresponding comments.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 qga/meson.build   | 8 ++++++++
 tests/meson.build | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/qga/meson.build b/qga/meson.build
index cfb1fbc085..79fcf91751 100644
--- a/qga/meson.build
+++ b/qga/meson.build
@@ -15,6 +15,14 @@ qga_qapi_outputs = [
   'qga-qapi-visit.h',
 ]
 
+# We don't generate trace-events, just because it's not simple. For do it,
+# we also should add .trace-events file into qga_qapi_outputs, and than
+# add corresponding element of qga_qapi_files into qapi_trace_events
+# global list, which is processed than in trace/meson.build.
+# This means, that we'll have to move subdir('qga') above subdir('trace')
+# in root meson.build. But that in turn will break the dependency of
+# qga on qemuutil (which depends on trace_ss).
+# So, resolving these dependencies and drop --no-trace-events is a TODO.
 qga_qapi_files = custom_target('QGA QAPI files',
                                output: qga_qapi_outputs,
                                input: 'qapi-schema.json',
diff --git a/tests/meson.build b/tests/meson.build
index 3f3882748a..21857d8b01 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -31,6 +31,14 @@ test_qapi_outputs = [
   'test-qapi-visit.h',
 ]
 
+# We don't generate trace-events, just because it's not simple. For do it,
+# we also should add .trace-events file into test_qapi_outputs, and than
+# add corresponding element of test_qapi_files into qapi_trace_events
+# global list, which is processed than in trace/meson.build.
+# This means, that we'll have to move subdir('tests') above subdir('trace')
+# in root meson.build. But that in turn will break the dependency of
+# tests on qemuutil (which depends on trace_ss).
+# So, resolving these dependencies and drop --no-trace-events is a TODO.
 test_qapi_files = custom_target('Test QAPI files',
                                 output: test_qapi_outputs,
                                 input: files('qapi-schema/qapi-schema-test.json',
-- 
2.31.1



  parent reply	other threads:[~2022-01-25 21:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 21:56 [PATCH v5 0/7] trace qmp commands Vladimir Sementsov-Ogievskiy
2022-01-25 21:56 ` [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module Vladimir Sementsov-Ogievskiy
2022-01-26 13:20   ` Stefan Hajnoczi
2022-01-26 14:32     ` Markus Armbruster
2022-01-26 14:03   ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 2/7] qapi/commands: refactor error handling code Vladimir Sementsov-Ogievskiy
2022-01-25 21:56 ` [PATCH v5 3/7] qapi/commands: Optionally generate trace for QMP commands Vladimir Sementsov-Ogievskiy
2022-01-26 14:03   ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 4/7] meson: generate trace events for qmp commands Vladimir Sementsov-Ogievskiy
2022-01-25 21:56 ` [PATCH v5 5/7] docs/qapi-code-gen: update to cover trace events code generation Vladimir Sementsov-Ogievskiy
2022-01-26 14:24   ` Markus Armbruster
2022-01-25 21:56 ` Vladimir Sementsov-Ogievskiy [this message]
2022-01-26 13:33   ` [PATCH v5 6/7] meson: document, why we don't generate trace events for tests/ and qga/ Stefan Hajnoczi
2022-01-26 13:34   ` Stefan Hajnoczi
2022-01-26 14:04   ` Markus Armbruster
2022-01-25 21:56 ` [PATCH v5 7/7] qapi: generate trace events by default Vladimir Sementsov-Ogievskiy
2022-01-26 14:04   ` Markus Armbruster
2022-01-26 13:35 ` [PATCH v5 0/7] trace qmp commands Stefan Hajnoczi
2022-01-26 14:33 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125215655.3111881-7-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).