* [PATCH] hw/arm: ast2600: Fix address mapping of second SPI controller
@ 2022-01-26 8:35 Cédric Le Goater
2022-01-26 12:21 ` Philippe Mathieu-Daudé via
2022-01-28 12:59 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Cédric Le Goater @ 2022-01-26 8:35 UTC (permalink / raw)
To: qemu-arm, qemu-devel
Cc: Andrew Jeffery, Peter Maydell, Troy Lee, Joel Stanley,
Cédric Le Goater
Address should be 0x1E631000 and not 0x1E641000 as initially introduced.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/838
Fixes: f25c0ae1079d ("aspeed/soc: Add AST2600 support")
Suggested-by: Troy Lee <troy_lee@aspeedtech.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/arm/aspeed_ast2600.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
index c3783bd87a25..568205fa6e9d 100644
--- a/hw/arm/aspeed_ast2600.c
+++ b/hw/arm/aspeed_ast2600.c
@@ -29,7 +29,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = {
[ASPEED_DEV_PWM] = 0x1E610000,
[ASPEED_DEV_FMC] = 0x1E620000,
[ASPEED_DEV_SPI1] = 0x1E630000,
- [ASPEED_DEV_SPI2] = 0x1E641000,
+ [ASPEED_DEV_SPI2] = 0x1E631000,
[ASPEED_DEV_EHCI1] = 0x1E6A1000,
[ASPEED_DEV_EHCI2] = 0x1E6A3000,
[ASPEED_DEV_MII1] = 0x1E650000,
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/arm: ast2600: Fix address mapping of second SPI controller
2022-01-26 8:35 [PATCH] hw/arm: ast2600: Fix address mapping of second SPI controller Cédric Le Goater
@ 2022-01-26 12:21 ` Philippe Mathieu-Daudé via
2022-01-28 12:59 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-26 12:21 UTC (permalink / raw)
To: Cédric Le Goater, qemu-arm, qemu-devel
Cc: Andrew Jeffery, Peter Maydell, Troy Lee, Joel Stanley
On 1/26/22 09:35, Cédric Le Goater wrote:
> Address should be 0x1E631000 and not 0x1E641000 as initially introduced.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/838
> Fixes: f25c0ae1079d ("aspeed/soc: Add AST2600 support")
> Suggested-by: Troy Lee <troy_lee@aspeedtech.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/arm/aspeed_ast2600.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c
> index c3783bd87a25..568205fa6e9d 100644
> --- a/hw/arm/aspeed_ast2600.c
> +++ b/hw/arm/aspeed_ast2600.c
> @@ -29,7 +29,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = {
> [ASPEED_DEV_PWM] = 0x1E610000,
> [ASPEED_DEV_FMC] = 0x1E620000,
> [ASPEED_DEV_SPI1] = 0x1E630000,
> - [ASPEED_DEV_SPI2] = 0x1E641000,
> + [ASPEED_DEV_SPI2] = 0x1E631000,
> [ASPEED_DEV_EHCI1] = 0x1E6A1000,
> [ASPEED_DEV_EHCI2] = 0x1E6A3000,
> [ASPEED_DEV_MII1] = 0x1E650000,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/arm: ast2600: Fix address mapping of second SPI controller
2022-01-26 8:35 [PATCH] hw/arm: ast2600: Fix address mapping of second SPI controller Cédric Le Goater
2022-01-26 12:21 ` Philippe Mathieu-Daudé via
@ 2022-01-28 12:59 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2022-01-28 12:59 UTC (permalink / raw)
To: Cédric Le Goater
Cc: Andrew Jeffery, qemu-arm, Troy Lee, qemu-devel, Joel Stanley
On Wed, 26 Jan 2022 at 08:35, Cédric Le Goater <clg@kaod.org> wrote:
>
> Address should be 0x1E631000 and not 0x1E641000 as initially introduced.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/838
> Fixes: f25c0ae1079d ("aspeed/soc: Add AST2600 support")
> Suggested-by: Troy Lee <troy_lee@aspeedtech.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/arm/aspeed_ast2600.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-28 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-26 8:35 [PATCH] hw/arm: ast2600: Fix address mapping of second SPI controller Cédric Le Goater
2022-01-26 12:21 ` Philippe Mathieu-Daudé via
2022-01-28 12:59 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).