From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 198F7C433F5 for ; Thu, 27 Jan 2022 17:26:36 +0000 (UTC) Received: from localhost ([::1]:46478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nD8Xb-0000xT-6c for qemu-devel@archiver.kernel.org; Thu, 27 Jan 2022 12:26:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD7rP-0006nw-Px for qemu-devel@nongnu.org; Thu, 27 Jan 2022 11:43:01 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD7rI-0008J8-QM for qemu-devel@nongnu.org; Thu, 27 Jan 2022 11:42:55 -0500 Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jl5rt0PcBz67ydD; Fri, 28 Jan 2022 00:39:10 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Thu, 27 Jan 2022 17:42:41 +0100 Received: from localhost (10.47.67.119) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 27 Jan 2022 16:42:40 +0000 Date: Thu, 27 Jan 2022 16:42:33 +0000 To: Alex =?ISO-8859-1?Q?Benn=E9e?= CC: , Marcel Apfelbaum , "Michael S . Tsirkin" , Igor Mammedov , , Ben Widawsky , "Peter Maydell" , , "Shameerali Kolothum Thodi" , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Saransh Gupta1 , Shreyas Shah , Chris Browy , Samarth Saxena , "Dan Williams" Subject: Re: [PATCH v4 00/42] CXl 2.0 emulation Support Message-ID: <20220127164233.00007514@Huawei.com> In-Reply-To: <87sft98d6f.fsf@linaro.org> References: <20220124171705.10432-1-Jonathan.Cameron@huawei.com> <87sft98d6f.fsf@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.47.67.119] X-ClientProxiedBy: lhreml741-chm.china.huawei.com (10.201.108.191) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Jonathan Cameron From: Jonathan Cameron via On Thu, 27 Jan 2022 14:22:52 +0000 Alex Benn=E9e wrote: > Jonathan Cameron writes: >=20 > > Previous version was RFC v3: CXL 2.0 Support. > > No longer an RFC as I would consider the vast majority of this > > to be ready for detailed review. There are still questions called > > out in some patches however. =20 >=20 > I've been through and added comments through the first half of the > patches. I'll see if I can get to the second half next week however if > you beat me to it with a re-rev I expect some ripples from the requested > changes. >=20 > Aside from ensuring the rest of the builds work: >=20 > https://gitlab.com/stsquad/qemu/-/pipelines/456700583/failures > =20 > it looks pretty good to me. I await the next version ;-) >=20 Thanks for ploughing through them - it's a great help. Hopefully I'll get a new version out before you get back to them. The CI certainly threw up some unexpected issues alongside the bugs and wrong assumptions and build issues you pointed out. * can't have a field called ERROR in a register on some archs * doesn't work if you don't push the tags on the tree... (win builds) but should be clean in next version. Thanks, Jonathan