From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Wen Congyang <wencongyang2@huawei.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH v4 14/19] blockjob: block_job_get_aio_context is a GS function
Date: Fri, 28 Jan 2022 06:50:26 -0500 [thread overview]
Message-ID: <20220128115031.4061565-15-eesposit@redhat.com> (raw)
In-Reply-To: <20220128115031.4061565-1-eesposit@redhat.com>
Move block_job_get_aio_context under the GS category in blockjob.h,
as it is always called with the BQL held.
This is done also to simplify the coming job->aiocontext protection.
For more infos about the GS API, see include/block/block-global-state.h
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
blockjob.c | 1 +
include/block/blockjob.h | 15 ++++++++-------
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index a6c94b6b64..04d868f020 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -568,5 +568,6 @@ BlockErrorAction block_job_error_action(BlockJob *job, BlockdevOnError on_err,
AioContext *block_job_get_aio_context(BlockJob *job)
{
+ assert(qemu_in_main_thread());
return job->job.aio_context;
}
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index a9a6cf2b84..376cd95877 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -169,6 +169,14 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error **errp);
*/
void block_job_iostatus_reset_locked(BlockJob *job);
+/*
+ * block_job_get_aio_context:
+ *
+ * Returns aio context associated with a block job.
+ */
+AioContext *block_job_get_aio_context(BlockJob *job);
+
+
/* Common functions that are neither I/O nor Global State */
/**
@@ -186,11 +194,4 @@ bool block_job_is_internal(BlockJob *job);
*/
const BlockJobDriver *block_job_driver(BlockJob *job);
-/*
- * block_job_get_aio_context:
- *
- * Returns aio context associated with a block job.
- */
-AioContext *block_job_get_aio_context(BlockJob *job);
-
#endif
--
2.31.1
next prev parent reply other threads:[~2022-01-28 12:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 11:50 [PATCH v4 00/19] job: replace AioContext lock with job_mutex Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 01/19] job.c: make job_mutex and job_lock/unlock() public Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 02/19] job.h: categorize fields in struct Job Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 03/19] job.c: make job_event_* functions static Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 04/19] job.c: move inner aiocontext lock in callbacks Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 05/19] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 06/19] jobs: remove aiocontext locks since the functions are under BQL Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 07/19] jobs: protect jobs with job_lock/unlock Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 08/19] jobs: add job lock in find_* functions Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 09/19] jobs: use job locks also in the unit tests Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 10/19] job.h: define locked functions Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 11/19] jobs: document all static functions and add _locked() suffix Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 12/19] job.h: define unlocked functions Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 13/19] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU Emanuele Giuseppe Esposito
2022-01-28 11:50 ` Emanuele Giuseppe Esposito [this message]
2022-01-28 11:50 ` [PATCH v4 15/19] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 16/19] job: detect change of aiocontext within job coroutine Emanuele Giuseppe Esposito
2022-01-31 10:03 ` Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 17/19] jobs: protect job.aio_context with BQL and job_mutex Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 18/19] job.c: enable job lock/unlock and remove Aiocontext locks Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 19/19] block_job_query: remove atomic read Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128115031.4061565-15-eesposit@redhat.com \
--to=eesposit@redhat.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).