From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Wen Congyang <wencongyang2@huawei.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH v4 15/19] commit and mirror: create new nodes using bdrv_get_aio_context, and not the job aiocontext
Date: Fri, 28 Jan 2022 06:50:27 -0500 [thread overview]
Message-ID: <20220128115031.4061565-16-eesposit@redhat.com> (raw)
In-Reply-To: <20220128115031.4061565-1-eesposit@redhat.com>
We are always using the given bs AioContext, so there is no need
to take the job ones (which is identical anyways).
This also reduces the point we need to check when protecting
job.aio_context field.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
block/commit.c | 4 ++--
block/mirror.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 2883a3ba52..3ea460fe4a 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -369,7 +369,7 @@ void commit_start(const char *job_id, BlockDriverState *bs,
goto fail;
}
- s->base = blk_new(s->common.job.aio_context,
+ s->base = blk_new(bdrv_get_aio_context(bs),
base_perms,
BLK_PERM_CONSISTENT_READ
| BLK_PERM_WRITE_UNCHANGED);
@@ -381,7 +381,7 @@ void commit_start(const char *job_id, BlockDriverState *bs,
s->base_bs = base;
/* Required permissions are already taken with block_job_add_bdrv() */
- s->top = blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL);
+ s->top = blk_new(bdrv_get_aio_context(bs), 0, BLK_PERM_ALL);
ret = blk_insert_bs(s->top, top, errp);
if (ret < 0) {
goto fail;
diff --git a/block/mirror.c b/block/mirror.c
index 0a3eb712e6..28d137407c 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1727,7 +1727,7 @@ static BlockJob *mirror_start_job(
goto fail;
}
- s->target = blk_new(s->common.job.aio_context,
+ s->target = blk_new(bdrv_get_aio_context(bs),
target_perms, target_shared_perms);
ret = blk_insert_bs(s->target, target, errp);
if (ret < 0) {
--
2.31.1
next prev parent reply other threads:[~2022-01-28 12:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 11:50 [PATCH v4 00/19] job: replace AioContext lock with job_mutex Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 01/19] job.c: make job_mutex and job_lock/unlock() public Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 02/19] job.h: categorize fields in struct Job Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 03/19] job.c: make job_event_* functions static Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 04/19] job.c: move inner aiocontext lock in callbacks Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 05/19] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 06/19] jobs: remove aiocontext locks since the functions are under BQL Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 07/19] jobs: protect jobs with job_lock/unlock Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 08/19] jobs: add job lock in find_* functions Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 09/19] jobs: use job locks also in the unit tests Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 10/19] job.h: define locked functions Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 11/19] jobs: document all static functions and add _locked() suffix Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 12/19] job.h: define unlocked functions Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 13/19] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 14/19] blockjob: block_job_get_aio_context is a GS function Emanuele Giuseppe Esposito
2022-01-28 11:50 ` Emanuele Giuseppe Esposito [this message]
2022-01-28 11:50 ` [PATCH v4 16/19] job: detect change of aiocontext within job coroutine Emanuele Giuseppe Esposito
2022-01-31 10:03 ` Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 17/19] jobs: protect job.aio_context with BQL and job_mutex Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 18/19] job.c: enable job lock/unlock and remove Aiocontext locks Emanuele Giuseppe Esposito
2022-01-28 11:50 ` [PATCH v4 19/19] block_job_query: remove atomic read Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128115031.4061565-16-eesposit@redhat.com \
--to=eesposit@redhat.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).