* [PATCH] hw/rx: rx-gdbsim: DTB load address fix.
@ 2022-01-31 9:42 Yoshinori Sato
2022-01-31 13:41 ` Philippe Mathieu-Daudé via
0 siblings, 1 reply; 2+ messages in thread
From: Yoshinori Sato @ 2022-01-31 9:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Yoshinori Sato
Linux kernel required alined address of DTB.
But missing align in dtb load function.
Fixed to load to the correct address.
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
hw/rx/rx-gdbsim.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c
index 75d1fec6ca..f70472aeaf 100644
--- a/hw/rx/rx-gdbsim.c
+++ b/hw/rx/rx-gdbsim.c
@@ -143,6 +143,7 @@ static void rx_gdbsim_init(MachineState *machine)
}
/* DTB is located at the end of SDRAM space. */
dtb_offset = machine->ram_size - dtb_size;
+ dtb_offset &= ~0x0f;
rom_add_blob_fixed("dtb", dtb, dtb_size,
SDRAM_BASE + dtb_offset);
/* Set dtb address to R1 */
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/rx: rx-gdbsim: DTB load address fix.
2022-01-31 9:42 [PATCH] hw/rx: rx-gdbsim: DTB load address fix Yoshinori Sato
@ 2022-01-31 13:41 ` Philippe Mathieu-Daudé via
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-31 13:41 UTC (permalink / raw)
To: Yoshinori Sato, qemu-devel, qemu-trivial
Cc'ing qemu-trivial@
On 31/1/22 10:42, Yoshinori Sato wrote:
> Linux kernel required alined address of DTB.
> But missing align in dtb load function.
> Fixed to load to the correct address.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> hw/rx/rx-gdbsim.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c
> index 75d1fec6ca..f70472aeaf 100644
> --- a/hw/rx/rx-gdbsim.c
> +++ b/hw/rx/rx-gdbsim.c
> @@ -143,6 +143,7 @@ static void rx_gdbsim_init(MachineState *machine)
> }
> /* DTB is located at the end of SDRAM space. */
> dtb_offset = machine->ram_size - dtb_size;
> + dtb_offset &= ~0x0f;
Alternatively (more explicit):
dtb_offset = ROUND_DOWN(machine->ram_size - dtb_size, 16);
For any option:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-31 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-31 9:42 [PATCH] hw/rx: rx-gdbsim: DTB load address fix Yoshinori Sato
2022-01-31 13:41 ` Philippe Mathieu-Daudé via
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).