* [PATCH] block.h: remove outdated comment
@ 2022-01-31 12:56 Emanuele Giuseppe Esposito
2022-01-31 23:58 ` Philippe Mathieu-Daudé via
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Emanuele Giuseppe Esposito @ 2022-01-31 12:56 UTC (permalink / raw)
To: qemu-block
Cc: Kevin Wolf, Emanuele Giuseppe Esposito, Hanna Reitz, qemu-devel
The comment "disk I/O throttling" doesn't make any sense at all
any more. It was added in commit 0563e191516 to describe
bdrv_io_limits_enable()/disable(), which were removed in commit
97148076, so the comment is just a forgotten leftover.
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
include/block/block.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/block/block.h b/include/block/block.h
index 9d4050220b..e1713ee306 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -344,7 +344,6 @@ typedef unsigned int BdrvChildRole;
char *bdrv_perm_names(uint64_t perm);
uint64_t bdrv_qapi_perm_to_blk_perm(BlockPermission qapi_perm);
-/* disk I/O throttling */
void bdrv_init(void);
void bdrv_init_with_whitelist(void);
bool bdrv_uses_whitelist(void);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] block.h: remove outdated comment
2022-01-31 12:56 [PATCH] block.h: remove outdated comment Emanuele Giuseppe Esposito
@ 2022-01-31 23:58 ` Philippe Mathieu-Daudé via
2022-02-01 12:29 ` Hanna Reitz
2022-02-01 12:39 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-31 23:58 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito, qemu-block
Cc: Kevin Wolf, Hanna Reitz, qemu-devel
On 31/1/22 13:56, Emanuele Giuseppe Esposito wrote:
> The comment "disk I/O throttling" doesn't make any sense at all
> any more. It was added in commit 0563e191516 to describe
> bdrv_io_limits_enable()/disable(), which were removed in commit
> 97148076, so the comment is just a forgotten leftover.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> include/block/block.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block.h: remove outdated comment
2022-01-31 12:56 [PATCH] block.h: remove outdated comment Emanuele Giuseppe Esposito
2022-01-31 23:58 ` Philippe Mathieu-Daudé via
@ 2022-02-01 12:29 ` Hanna Reitz
2022-02-01 12:39 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Hanna Reitz @ 2022-02-01 12:29 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 31.01.22 13:56, Emanuele Giuseppe Esposito wrote:
> The comment "disk I/O throttling" doesn't make any sense at all
> any more. It was added in commit 0563e191516 to describe
> bdrv_io_limits_enable()/disable(), which were removed in commit
> 97148076, so the comment is just a forgotten leftover.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> include/block/block.h | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to my block branch:
https://gitlab.com/hreitz/qemu/-/commits/block
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block.h: remove outdated comment
2022-01-31 12:56 [PATCH] block.h: remove outdated comment Emanuele Giuseppe Esposito
2022-01-31 23:58 ` Philippe Mathieu-Daudé via
2022-02-01 12:29 ` Hanna Reitz
@ 2022-02-01 12:39 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2022-02-01 12:39 UTC (permalink / raw)
To: Emanuele Giuseppe Esposito; +Cc: Hanna Reitz, qemu-devel, qemu-block
Am 31.01.2022 um 13:56 hat Emanuele Giuseppe Esposito geschrieben:
> The comment "disk I/O throttling" doesn't make any sense at all
> any more. It was added in commit 0563e191516 to describe
> bdrv_io_limits_enable()/disable(), which were removed in commit
> 97148076, so the comment is just a forgotten leftover.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-01 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-31 12:56 [PATCH] block.h: remove outdated comment Emanuele Giuseppe Esposito
2022-01-31 23:58 ` Philippe Mathieu-Daudé via
2022-02-01 12:29 ` Hanna Reitz
2022-02-01 12:39 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).