From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
thuth@redhat.com, lvivier@redhat.com, peter.maydell@linaro.org,
drjones@redhat.com, f4bug@amsat.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: [PATCH 1/2] hw/arm/virt: Fix gic-version=max when CONFIG_ARM_GIC_TCG is unset
Date: Mon, 31 Jan 2022 16:45:30 +0100 [thread overview]
Message-ID: <20220131154531.429533-2-eric.auger@redhat.com> (raw)
In-Reply-To: <20220131154531.429533-1-eric.auger@redhat.com>
In TCG mode, if gic-version=max we always select GICv3 even if
CONFIG_ARM_GIC_TCG is unset. We shall rather select GICv2.
This also brings the benefit of fixing qos tests errors for tests
using gic-version=max with CONFIG_ARM_GIC_TCG unset.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Fixes: a8a5546798c3 ("hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector")
---
hw/arm/virt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 141350bf21..2f1d4d0230 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1852,7 +1852,11 @@ static void finalize_gic_version(VirtMachineState *vms)
vms->gic_version = VIRT_GIC_VERSION_2;
break;
case VIRT_GIC_VERSION_MAX:
+#ifdef CONFIG_ARM_GIC_TCG
vms->gic_version = VIRT_GIC_VERSION_3;
+#else
+ vms->gic_version = VIRT_GIC_VERSION_2;
+#endif
break;
case VIRT_GIC_VERSION_HOST:
error_report("gic-version=host requires KVM");
--
2.26.3
next prev parent reply other threads:[~2022-01-31 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 15:45 [PATCH 0/2] hw/arm/virt, qtests: Fix make check-qtest-aarch64 when CONFIG_ARM_GIC_TCG is unset Eric Auger
2022-01-31 15:45 ` Eric Auger [this message]
2022-01-31 15:53 ` [PATCH 1/2] hw/arm/virt: Fix gic-version=max " Andrew Jones
2022-01-31 15:45 ` [PATCH 2/2] tests/qtest: Special case sbsa-ref and xlnx-versal-virt if !CONFIG_ARM_GIC_TCG Eric Auger
2022-01-31 15:59 ` Andrew Jones
2022-01-31 16:05 ` Peter Maydell
2022-01-31 16:14 ` Andrew Jones
2022-01-31 16:18 ` Peter Maydell
2022-01-31 16:18 ` Eric Auger
2022-01-31 16:15 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131154531.429533-2-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).