qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: Helge Deller <deller@gmx.de>, Sven Schnelle <svens@stackframe.org>
Subject: [PATCH v2 6/6] hw/display/artist: Fix draw_line() artefacts
Date: Mon, 31 Jan 2022 22:35:29 +0100	[thread overview]
Message-ID: <20220131213529.17404-7-deller@gmx.de> (raw)
In-Reply-To: <20220131213529.17404-1-deller@gmx.de>

From: Sven Schnelle <svens@stackframe.org>

The draw_line() function left artefacts on the screen because it was using the
x/y variables which were incremented in the loop before. Fix it by using the
unmodified x1/x2 variables instead.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: qemu-stable@nongnu.org
Signed-off-by: Helge Deller <deller@gmx.de>
---
 hw/display/artist.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/display/artist.c b/hw/display/artist.c
index 8a9fa482d0..1d877998b9 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -553,10 +553,11 @@ static void draw_line(ARTISTState *s,
         }
         x++;
     } while (x <= x2 && (max_pix == -1 || --max_pix > 0));
+
     if (c1)
-        artist_invalidate_lines(buf, x, dy+1);
+        artist_invalidate_lines(buf, x1, x2 - x1);
     else
-        artist_invalidate_lines(buf, y, dx+1);
+        artist_invalidate_lines(buf, y1 > y2 ? y2 : y1, x2 - x1);
 }

 static void draw_line_pattern_start(ARTISTState *s)
--
2.34.1



      parent reply	other threads:[~2022-01-31 21:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 21:35 [PATCH v2 0/6] Fixes and updates for hppa target Helge Deller
2022-01-31 21:35 ` [PATCH v2 1/6] seabios-hppa: Update SeaBIOS-hppa to VERSION 3 Helge Deller
2022-01-31 21:35 ` [PATCH v2 2/6] hw/hppa: Allow up to 16 emulated CPUs Helge Deller
2022-01-31 22:05   ` Richard Henderson
2022-02-01  9:37     ` Helge Deller
2022-01-31 21:35 ` [PATCH v2 3/6] hppa: Add support for an emulated TOC/NMI button Helge Deller
2022-01-31 22:06   ` Richard Henderson
2022-01-31 23:56   ` Philippe Mathieu-Daudé via
2024-05-29 15:11     ` Philippe Mathieu-Daudé
2024-05-29 20:06       ` Helge Deller
2022-01-31 21:35 ` [PATCH v2 4/6] hw/display/artist: rewrite vram access mode handling Helge Deller
2022-01-31 21:35 ` [PATCH v2 5/6] hw/display/artist: Mouse cursor fixes for HP-UX Helge Deller
2022-01-31 21:35 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220131213529.17404-7-deller@gmx.de \
    --to=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).