* [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too
@ 2022-02-01 8:55 Thomas Huth
2022-02-01 9:26 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2022-02-01 8:55 UTC (permalink / raw)
To: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
Cc: qemu-trivial, Daniel P . Berrangé, Beraldo Leal,
Wainer dos Santos Moschetta
When running "make lcitool-refresh" in an out-of-tree build, it
currently fails with an error message from git like this:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Fix it by changing to the source directory first before updating
the submodule.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/lcitool/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/Makefile.include b/tests/lcitool/Makefile.include
index cff7c0b814..6b215adcd1 100644
--- a/tests/lcitool/Makefile.include
+++ b/tests/lcitool/Makefile.include
@@ -13,5 +13,5 @@ lcitool:
lcitool-help: lcitool
lcitool-refresh:
- $(call quiet-command, git submodule update --init $(SRC_PATH)/tests/lcitool/libvirt-ci)
+ $(call quiet-command, cd $(SRC_PATH) && git submodule update --init tests/lcitool/libvirt-ci)
$(call quiet-command, $(LCITOOL_REFRESH))
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too
2022-02-01 8:55 [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too Thomas Huth
@ 2022-02-01 9:26 ` Daniel P. Berrangé
2022-02-01 10:17 ` Alex Bennée
2022-02-01 10:54 ` Philippe Mathieu-Daudé via
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2022-02-01 9:26 UTC (permalink / raw)
To: Thomas Huth
Cc: Beraldo Leal, qemu-trivial, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé,
Alex Bennée
On Tue, Feb 01, 2022 at 09:55:54AM +0100, Thomas Huth wrote:
> When running "make lcitool-refresh" in an out-of-tree build, it
> currently fails with an error message from git like this:
>
> fatal: not a git repository (or any parent up to mount point /)
> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>
> Fix it by changing to the source directory first before updating
> the submodule.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/lcitool/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too
2022-02-01 8:55 [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too Thomas Huth
2022-02-01 9:26 ` Daniel P. Berrangé
@ 2022-02-01 10:17 ` Alex Bennée
2022-02-01 10:54 ` Philippe Mathieu-Daudé via
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2022-02-01 10:17 UTC (permalink / raw)
To: Thomas Huth
Cc: Daniel P . Berrangé, Beraldo Leal, qemu-trivial, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
Thomas Huth <thuth@redhat.com> writes:
> When running "make lcitool-refresh" in an out-of-tree build, it
> currently fails with an error message from git like this:
>
> fatal: not a git repository (or any parent up to mount point /)
> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>
> Fix it by changing to the source directory first before updating
> the submodule.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too
2022-02-01 8:55 [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too Thomas Huth
2022-02-01 9:26 ` Daniel P. Berrangé
2022-02-01 10:17 ` Alex Bennée
@ 2022-02-01 10:54 ` Philippe Mathieu-Daudé via
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-02-01 10:54 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Alex Bennée
Cc: qemu-trivial, Wainer dos Santos Moschetta, Beraldo Leal,
Daniel P . Berrangé
On 2/1/22 09:55, Thomas Huth wrote:
> When running "make lcitool-refresh" in an out-of-tree build, it
> currently fails with an error message from git like this:
>
> fatal: not a git repository (or any parent up to mount point /)
> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>
> Fix it by changing to the source directory first before updating
> the submodule.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/lcitool/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-01 11:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-01 8:55 [PATCH] tests/lcitool: Allow lcitool-refresh in out-of-tree builds, too Thomas Huth
2022-02-01 9:26 ` Daniel P. Berrangé
2022-02-01 10:17 ` Alex Bennée
2022-02-01 10:54 ` Philippe Mathieu-Daudé via
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).