qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Hanna Reitz <hreitz@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org
Subject: [PULL 10/24] iotest 065: explicit compression type
Date: Tue,  1 Feb 2022 15:42:19 +0100	[thread overview]
Message-ID: <20220201144233.617021-11-hreitz@redhat.com> (raw)
In-Reply-To: <20220201144233.617021-1-hreitz@redhat.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

The test checks different options. It of course fails if set
IMGOPTS='compression_type=zstd'. So, let's be explicit in what
compression type we want and independent of IMGOPTS. Test both existing
compression types.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20211223160144.1097696-9-vsementsov@virtuozzo.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
 tests/qemu-iotests/065 | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/qemu-iotests/065 b/tests/qemu-iotests/065
index dc7716275f..f7c1b68dad 100755
--- a/tests/qemu-iotests/065
+++ b/tests/qemu-iotests/065
@@ -88,7 +88,7 @@ class TestQMP(TestImageInfoSpecific):
 
 class TestQCow2(TestQemuImgInfo):
     '''Testing a qcow2 version 2 image'''
-    img_options = 'compat=0.10'
+    img_options = 'compat=0.10,compression_type=zlib'
     json_compare = { 'compat': '0.10', 'refcount-bits': 16,
                      'compression-type': 'zlib' }
     human_compare = [ 'compat: 0.10', 'compression type: zlib',
@@ -96,17 +96,17 @@ class TestQCow2(TestQemuImgInfo):
 
 class TestQCow3NotLazy(TestQemuImgInfo):
     '''Testing a qcow2 version 3 image with lazy refcounts disabled'''
-    img_options = 'compat=1.1,lazy_refcounts=off'
+    img_options = 'compat=1.1,lazy_refcounts=off,compression_type=zstd'
     json_compare = { 'compat': '1.1', 'lazy-refcounts': False,
                      'refcount-bits': 16, 'corrupt': False,
-                     'compression-type': 'zlib', 'extended-l2': False }
-    human_compare = [ 'compat: 1.1', 'compression type: zlib',
+                     'compression-type': 'zstd', 'extended-l2': False }
+    human_compare = [ 'compat: 1.1', 'compression type: zstd',
                       'lazy refcounts: false', 'refcount bits: 16',
                       'corrupt: false', 'extended l2: false' ]
 
 class TestQCow3Lazy(TestQemuImgInfo):
     '''Testing a qcow2 version 3 image with lazy refcounts enabled'''
-    img_options = 'compat=1.1,lazy_refcounts=on'
+    img_options = 'compat=1.1,lazy_refcounts=on,compression_type=zlib'
     json_compare = { 'compat': '1.1', 'lazy-refcounts': True,
                      'refcount-bits': 16, 'corrupt': False,
                      'compression-type': 'zlib', 'extended-l2': False }
@@ -117,7 +117,7 @@ class TestQCow3Lazy(TestQemuImgInfo):
 class TestQCow3NotLazyQMP(TestQMP):
     '''Testing a qcow2 version 3 image with lazy refcounts disabled, opening
        with lazy refcounts enabled'''
-    img_options = 'compat=1.1,lazy_refcounts=off'
+    img_options = 'compat=1.1,lazy_refcounts=off,compression_type=zlib'
     qemu_options = 'lazy-refcounts=on'
     compare = { 'compat': '1.1', 'lazy-refcounts': False,
                 'refcount-bits': 16, 'corrupt': False,
@@ -127,11 +127,11 @@ class TestQCow3NotLazyQMP(TestQMP):
 class TestQCow3LazyQMP(TestQMP):
     '''Testing a qcow2 version 3 image with lazy refcounts enabled, opening
        with lazy refcounts disabled'''
-    img_options = 'compat=1.1,lazy_refcounts=on'
+    img_options = 'compat=1.1,lazy_refcounts=on,compression_type=zstd'
     qemu_options = 'lazy-refcounts=off'
     compare = { 'compat': '1.1', 'lazy-refcounts': True,
                 'refcount-bits': 16, 'corrupt': False,
-                'compression-type': 'zlib', 'extended-l2': False }
+                'compression-type': 'zstd', 'extended-l2': False }
 
 TestImageInfoSpecific = None
 TestQemuImgInfo = None
-- 
2.34.1



  parent reply	other threads:[~2022-02-01 15:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 14:42 [PULL 00/24] Block patches Hanna Reitz
2022-02-01 14:42 ` [PULL 01/24] tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a' Hanna Reitz
2022-02-01 14:42 ` [PULL 02/24] iotests/MRCE: Write data to source Hanna Reitz
2022-02-01 14:42 ` [PULL 03/24] iotests.py: img_info_log(): rename imgopts argument Hanna Reitz
2022-02-01 14:42 ` [PULL 04/24] iotests.py: implement unsupported_imgopts Hanna Reitz
2022-02-01 14:42 ` [PULL 05/24] iotests: specify some unsupported_imgopts for python iotests Hanna Reitz
2022-02-01 14:42 ` [PULL 06/24] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd' Hanna Reitz
2022-02-01 14:42 ` [PULL 07/24] iotests: drop qemu_img_verbose() helper Hanna Reitz
2022-02-01 14:42 ` [PULL 08/24] iotests.py: rewrite default luks support in qemu_img Hanna Reitz
2022-02-01 14:42 ` [PULL 09/24] iotest 303: explicit compression type Hanna Reitz
2022-02-01 14:42 ` Hanna Reitz [this message]
2022-02-14 19:53   ` [PULL 10/24] iotest 065: " Thomas Huth
2022-02-01 14:42 ` [PULL 11/24] iotests.py: filter out successful output of qemu-img create Hanna Reitz
2022-02-01 14:42 ` [PULL 12/24] iotests.py: filter compression type out Hanna Reitz
2022-02-01 14:42 ` [PULL 13/24] iotest 302: use img_info_log() helper Hanna Reitz
2022-02-01 14:42 ` [PULL 14/24] qcow2: simple case support for downgrading of qcow2 images with zstd Hanna Reitz
2022-02-01 14:42 ` [PULL 15/24] iotests/common.rc: introduce _qcow2_dump_header helper Hanna Reitz
2022-02-01 14:42 ` [PULL 16/24] iotests: massive use _qcow2_dump_header Hanna Reitz
2022-02-01 14:42 ` [PULL 17/24] iotest 39: " Hanna Reitz
2022-02-01 14:42 ` [PULL 18/24] iotests: bash tests: filter compression type Hanna Reitz
2022-02-01 14:42 ` [PULL 19/24] iotests 60: more accurate set dirty bit in qcow2 header Hanna Reitz
2022-02-01 14:42 ` [PULL 20/24] iotest 214: explicit compression type Hanna Reitz
2022-02-01 14:42 ` [PULL 21/24] iotests: declare lack of support for compresion_type in IMGOPTS Hanna Reitz
2022-02-01 14:42 ` [PULL 22/24] block-backend: Retain permissions after migration Hanna Reitz
2022-02-01 14:42 ` [PULL 23/24] iotests/migration-permissions: New test Hanna Reitz
2022-02-01 14:42 ` [PULL 24/24] block.h: remove outdated comment Hanna Reitz
2022-02-01 19:47 ` [PULL 00/24] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201144233.617021-11-hreitz@redhat.com \
    --to=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).