From: Halil Pasic <pasic@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Daniel Henrique Barboza <danielhb@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Halil Pasic <pasic@linux.ibm.com>,
Jakob Naucke <Jakob.Naucke@ibm.com>
Subject: Re: [PATCH v3 1/1] virtio: fix the condition for iommu_platform not supported
Date: Tue, 1 Feb 2022 18:50:01 +0100 [thread overview]
Message-ID: <20220201185001.41d467a3.pasic@linux.ibm.com> (raw)
In-Reply-To: <20220201115136-mutt-send-email-mst@kernel.org>
On Tue, 1 Feb 2022 11:52:06 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> > > + bool vdev_has_iommu = false;
> >
> > Isn't vdev_has_iommu set unconditionally before you try to use it?
>
> I'd like to know too.
Yes it is. Was meant as a conservative thing. AFAIR in C stuff on stack
is not initialized to anything in particular so the idea was better
use false than garbage if someone made a mistake. But on the other
hand compilers can warn about that, and this defeats the compiler
warning. So uninitialized is indeed better.
prev parent reply other threads:[~2022-02-01 19:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 13:39 [PATCH v3 1/1] virtio: fix the condition for iommu_platform not supported Halil Pasic
2022-02-01 15:36 ` Daniel Henrique Barboza
2022-02-01 18:33 ` Halil Pasic
2022-02-01 19:31 ` Daniel Henrique Barboza
2022-02-02 1:15 ` Halil Pasic
2022-02-02 7:06 ` Michael S. Tsirkin
2022-02-02 13:16 ` Halil Pasic
2022-02-02 13:24 ` Daniel Henrique Barboza
2022-02-02 16:23 ` Halil Pasic
2022-02-02 16:27 ` Daniel Henrique Barboza
2022-02-02 16:50 ` Michael S. Tsirkin
2022-02-01 16:05 ` Halil Pasic
2022-02-01 16:47 ` Cornelia Huck
2022-02-01 16:52 ` Michael S. Tsirkin
2022-02-01 17:50 ` Halil Pasic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201185001.41d467a3.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=Jakob.Naucke@ibm.com \
--cc=brijesh.singh@amd.com \
--cc=cohuck@redhat.com \
--cc=danielhb@linux.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).