* [PATCH] qemu-options: fix incorrect description for '-drive index='
@ 2022-02-02 14:34 Laurent Vivier
2022-02-03 7:26 ` Thomas Huth
2022-02-21 17:33 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2022-02-02 14:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Laurent Vivier, Thomas Huth
qemu-options.hx contains grammar that a native English-speaking
person would never use.
Replace "This option defines where is connected the drive" by
"This option defines where the drive is connected".
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index ba3ae6a42aa3..094a6c1d7c28 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1377,7 +1377,7 @@ SRST
the bus number and the unit id.
``index=index``
- This option defines where is connected the drive by using an
+ This option defines where the drive is connected by using an
index in the list of available connectors of a given interface
type.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qemu-options: fix incorrect description for '-drive index='
2022-02-02 14:34 [PATCH] qemu-options: fix incorrect description for '-drive index=' Laurent Vivier
@ 2022-02-03 7:26 ` Thomas Huth
2022-02-21 17:33 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2022-02-03 7:26 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial
On 02/02/2022 15.34, Laurent Vivier wrote:
> qemu-options.hx contains grammar that a native English-speaking
> person would never use.
>
> Replace "This option defines where is connected the drive" by
> "This option defines where the drive is connected".
>
> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853
I'd prefer:
Fixes: e0e7ada1d5 ("Update documention with '-drive' usage")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/853
but anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ba3ae6a42aa3..094a6c1d7c28 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1377,7 +1377,7 @@ SRST
> the bus number and the unit id.
>
> ``index=index``
> - This option defines where is connected the drive by using an
> + This option defines where the drive is connected by using an
> index in the list of available connectors of a given interface
> type.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qemu-options: fix incorrect description for '-drive index='
2022-02-02 14:34 [PATCH] qemu-options: fix incorrect description for '-drive index=' Laurent Vivier
2022-02-03 7:26 ` Thomas Huth
@ 2022-02-21 17:33 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2022-02-21 17:33 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: qemu-trivial, Thomas Huth
Le 02/02/2022 à 15:34, Laurent Vivier a écrit :
> qemu-options.hx contains grammar that a native English-speaking
> person would never use.
>
> Replace "This option defines where is connected the drive" by
> "This option defines where the drive is connected".
>
> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index ba3ae6a42aa3..094a6c1d7c28 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1377,7 +1377,7 @@ SRST
> the bus number and the unit id.
>
> ``index=index``
> - This option defines where is connected the drive by using an
> + This option defines where the drive is connected by using an
> index in the list of available connectors of a given interface
> type.
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-21 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-02 14:34 [PATCH] qemu-options: fix incorrect description for '-drive index=' Laurent Vivier
2022-02-03 7:26 ` Thomas Huth
2022-02-21 17:33 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).