From: Jimmy Brisson <jimmy.brisson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"open list:MPS2" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Jimmy Brisson <jimmy.brisson@linaro.org>
Subject: [PATCH v1] an547: Correct typo that swaps ahb and apb peripherals
Date: Wed, 2 Feb 2022 09:23:23 -0600 [thread overview]
Message-ID: <20220202152323.2529767-1-jimmy.brisson@linaro.org> (raw)
Turns out that this manifests in being unable to configure
the ethernet access permissions, as the IotKitPPC looks
these up by name.
With this fix, eth is configurable
Signed-off-by: Jimmy Brisson <jimmy.brisson@linaro.org>
---
hw/arm/mps2-tz.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c
index f40e854dec..3c6456762a 100644
--- a/hw/arm/mps2-tz.c
+++ b/hw/arm/mps2-tz.c
@@ -1030,7 +1030,7 @@ static void mps2tz_common_init(MachineState *machine)
};
const PPCInfo an547_ppcs[] = { {
- .name = "apb_ppcexp0",
+ .name = "ahb_ppcexp0",
.ports = {
{ "ssram-mpc", make_mpc, &mms->mpc[0], 0x57000000, 0x1000 },
{ "qspi-mpc", make_mpc, &mms->mpc[1], 0x57001000, 0x1000 },
@@ -1072,7 +1072,7 @@ static void mps2tz_common_init(MachineState *machine)
{ "rtc", make_rtc, &mms->rtc, 0x4930b000, 0x1000 },
},
}, {
- .name = "ahb_ppcexp0",
+ .name = "apb_ppcexp0",
.ports = {
{ "gpio0", make_unimp_dev, &mms->gpio[0], 0x41100000, 0x1000 },
{ "gpio1", make_unimp_dev, &mms->gpio[1], 0x41101000, 0x1000 },
--
2.33.1
next reply other threads:[~2022-02-02 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 15:23 Jimmy Brisson [this message]
2022-02-04 17:14 ` [PATCH v1] an547: Correct typo that swaps ahb and apb peripherals Peter Maydell
2022-02-10 15:13 ` Jimmy Brisson
2022-02-10 20:07 ` Jimmy Brisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202152323.2529767-1-jimmy.brisson@linaro.org \
--to=jimmy.brisson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).