From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: [PATCH 2/7] tests/qtest: failover: use a macro for check_one_card()
Date: Thu, 3 Feb 2022 15:15:32 +0100 [thread overview]
Message-ID: <20220203141537.972317-3-lvivier@redhat.com> (raw)
In-Reply-To: <20220203141537.972317-1-lvivier@redhat.com>
This allows g_assert() to correctly report the line number of the error
in the test case.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tests/qtest/virtio-net-failover.c | 47 ++++++++++++++-----------------
1 file changed, 21 insertions(+), 26 deletions(-)
diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c
index 207c1330125b..070e53de1292 100644
--- a/tests/qtest/virtio-net-failover.c
+++ b/tests/qtest/virtio-net-failover.c
@@ -224,32 +224,27 @@ static char *get_mac(QTestState *qts, const char *name)
return mac;
}
-static void check_one_card(QTestState *qts, bool present,
- const char *id, const char *mac)
-{
- QDict *device;
- QDict *bus;
- char *addr;
-
- bus = get_bus(qts, 0);
- device = find_device(bus, id);
- if (present) {
- char *path;
-
- g_assert_nonnull(device);
- qobject_unref(device);
-
- path = g_strdup_printf("/machine/peripheral/%s", id);
- addr = get_mac(qts, path);
- g_free(path);
- g_assert_cmpstr(mac, ==, addr);
- g_free(addr);
- } else {
- g_assert_null(device);
- }
-
- qobject_unref(bus);
-}
+#define check_one_card(qts, present, id, mac) \
+do { \
+ QDict *device; \
+ QDict *bus; \
+ char *addr; \
+ bus = get_bus(qts, 0); \
+ device = find_device(bus, id); \
+ if (present) { \
+ char *path; \
+ g_assert_nonnull(device); \
+ qobject_unref(device); \
+ path = g_strdup_printf("/machine/peripheral/%s", id); \
+ addr = get_mac(qts, path); \
+ g_free(path); \
+ g_assert_cmpstr(mac, ==, addr); \
+ g_free(addr); \
+ } else { \
+ g_assert_null(device); \
+ } \
+ qobject_unref(bus); \
+} while (0)
static void test_on(void)
{
--
2.34.1
next prev parent reply other threads:[~2022-02-03 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 14:15 [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2) Laurent Vivier
2022-02-03 14:15 ` [PATCH 1/7] tests/qtest: failover: clean up pathname of tests Laurent Vivier
2022-02-03 14:15 ` Laurent Vivier [this message]
2022-02-03 14:15 ` [PATCH 3/7] tests/qtest: failover: check the feature is correctly provided Laurent Vivier
2022-02-03 14:15 ` [PATCH 4/7] tests/qtest: failover: check missing guest feature Laurent Vivier
2022-02-03 14:15 ` [PATCH 5/7] tests/qtest: failover: check migration with failover off Laurent Vivier
2022-02-03 14:15 ` [PATCH 6/7] tests/qtest: failover: test migration if the guest doesn't support failover Laurent Vivier
2022-02-03 14:15 ` [PATCH 7/7] tests/qtest: failover: migration abort test with failover off Laurent Vivier
2022-02-15 9:20 ` [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2) Laurent Vivier
2022-02-21 9:17 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203141537.972317-3-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).