From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: [PATCH 4/7] tests/qtest: failover: check missing guest feature
Date: Thu, 3 Feb 2022 15:15:34 +0100 [thread overview]
Message-ID: <20220203141537.972317-5-lvivier@redhat.com> (raw)
In-Reply-To: <20220203141537.972317-1-lvivier@redhat.com>
If QEMU provides the VIRTIO_NET_F_STANDBY feature but the guest doesn't
the primary device must be kept hidden
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tests/qtest/virtio-net-failover.c | 33 +++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tests/qtest/virtio-net-failover.c b/tests/qtest/virtio-net-failover.c
index 42367963685c..cbd8585fa853 100644
--- a/tests/qtest/virtio-net-failover.c
+++ b/tests/qtest/virtio-net-failover.c
@@ -404,6 +404,38 @@ static void test_enabled(void)
machine_stop(qts);
}
+static void test_guest_off(void)
+{
+ QTestState *qts;
+ QVirtioPCIDevice *vdev;
+ uint64_t features;
+
+ qts = machine_start(BASE_MACHINE
+ "-netdev user,id=hs0 "
+ "-device virtio-net,bus=root0,id=standby0,"
+ "failover=on,netdev=hs0,mac="MAC_STANDBY0" "
+ "-netdev user,id=hs1 "
+ "-device virtio-net,bus=root1,id=primary0,"
+ "failover_pair_id=standby0,netdev=hs1,mac="MAC_PRIMARY0" ",
+ 2);
+
+ check_one_card(qts, true, "standby0", MAC_STANDBY0);
+ check_one_card(qts, false, "primary0", MAC_PRIMARY0);
+
+ features = ~(QVIRTIO_F_BAD_FEATURE |
+ (1ull << VIRTIO_RING_F_INDIRECT_DESC) |
+ (1ull << VIRTIO_RING_F_EVENT_IDX) |
+ (1ull << VIRTIO_NET_F_STANDBY));
+
+ vdev = start_virtio_net_internal(qts, 1, 0, &features);
+
+ check_one_card(qts, true, "standby0", MAC_STANDBY0);
+ check_one_card(qts, false, "primary0", MAC_PRIMARY0);
+
+ qos_object_destroy((QOSGraphObject *)vdev);
+ machine_stop(qts);
+}
+
static void test_hotplug_1(void)
{
QTestState *qts;
@@ -1351,6 +1383,7 @@ int main(int argc, char **argv)
test_on_mismatch);
qtest_add_func("failover-virtio-net/params/off", test_off);
qtest_add_func("failover-virtio-net/params/enabled", test_enabled);
+ qtest_add_func("failover-virtio-net/params/guest_off", test_guest_off);
/* hotplug tests */
qtest_add_func("failover-virtio-net/hotplug/1", test_hotplug_1);
--
2.34.1
next prev parent reply other threads:[~2022-02-03 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 14:15 [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2) Laurent Vivier
2022-02-03 14:15 ` [PATCH 1/7] tests/qtest: failover: clean up pathname of tests Laurent Vivier
2022-02-03 14:15 ` [PATCH 2/7] tests/qtest: failover: use a macro for check_one_card() Laurent Vivier
2022-02-03 14:15 ` [PATCH 3/7] tests/qtest: failover: check the feature is correctly provided Laurent Vivier
2022-02-03 14:15 ` Laurent Vivier [this message]
2022-02-03 14:15 ` [PATCH 5/7] tests/qtest: failover: check migration with failover off Laurent Vivier
2022-02-03 14:15 ` [PATCH 6/7] tests/qtest: failover: test migration if the guest doesn't support failover Laurent Vivier
2022-02-03 14:15 ` [PATCH 7/7] tests/qtest: failover: migration abort test with failover off Laurent Vivier
2022-02-15 9:20 ` [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2) Laurent Vivier
2022-02-21 9:17 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203141537.972317-5-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).