From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com
Subject: [PATCH 18/27] qga/vss-win32: fix midl arguments
Date: Thu, 3 Feb 2022 18:33:50 +0100 [thread overview]
Message-ID: <20220203173359.292068-19-pbonzini@redhat.com> (raw)
In-Reply-To: <20220203173359.292068-1-pbonzini@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Microsoft midl compiler doesn't take "-options" form, nor does it take
OUTPUT filename. The -I option seems needless as well (at least with
VS15).
It's not clear what was actually used when it was introduced in commit
b39297aedfabe9.
strings says "Created by MIDL version 7.00.0555 at Fri Dec 21 13:36:39
2012".
I doubt the makefile rule actually ever worked.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qga/vss-win32/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build
index 90825edef3..78bdf5e74a 100644
--- a/qga/vss-win32/meson.build
+++ b/qga/vss-win32/meson.build
@@ -26,8 +26,7 @@ if midl.found()
gen_tlb = custom_target('gen-tlb',
input: 'qga-vss.idl',
output: 'qga-vss.tlb',
- command: [midl, '-tlb', '-I' + config_host['WIN_SDK'],
- '@INPUT@', '@OUTPUT@'])
+ command: [midl, '@INPUT@', '/tlb', '@OUTPUT@'])
else
gen_tlb = custom_target('gen-tlb',
input: 'qga-vss.tlb',
--
2.34.1
next prev parent reply other threads:[~2022-02-03 18:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 17:33 [PATCH 00/27] Next batch of Meson cleanups and conversions Paolo Bonzini
2022-02-03 17:33 ` [PATCH 01/27] meson: use .allowed() method for features Paolo Bonzini
2022-02-04 3:47 ` Richard Henderson
2022-02-03 17:33 ` [PATCH 02/27] meson: use .require() and .disable_auto_if() " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 03/27] configure, meson: move AVX tests to meson Paolo Bonzini
2022-02-04 4:07 ` Richard Henderson
2022-02-03 17:33 ` [PATCH 04/27] configure, meson: move membarrier test " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 05/27] configure, meson: move AF_ALG " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 06/27] configure, meson: move libnuma detection " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 07/27] configure, meson: move TPM check " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 08/27] configure, meson: cleanup qemu-ga libraries Paolo Bonzini
2022-02-03 17:33 ` [PATCH 09/27] configure, meson: move image format options to meson_options.txt Paolo Bonzini
2022-02-03 17:33 ` [PATCH 10/27] configure, meson: move block layer " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 11/27] meson: define qemu_cflags/qemu_ldflags Paolo Bonzini
2022-02-04 5:08 ` Philippe Mathieu-Daudé via
2022-02-03 17:33 ` [PATCH 12/27] configure, meson: move some default-disabled options to meson_options.txt Paolo Bonzini
2022-02-03 17:33 ` [PATCH 13/27] configure, meson: move coroutine " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 14/27] configure, meson: move smbd " Paolo Bonzini
2022-02-03 17:33 ` [PATCH 15/27] configure, meson: move guest-agent, tools to meson Paolo Bonzini
2022-02-03 17:33 ` [PATCH 16/27] meson: refine check for whether to look for virglrenderer Paolo Bonzini
2022-02-03 17:33 ` [PATCH 17/27] configure, meson: move OpenGL check to meson Paolo Bonzini
2022-02-03 17:33 ` Paolo Bonzini [this message]
2022-02-08 11:13 ` [PATCH 18/27] qga/vss-win32: fix midl arguments Konstantin Kostiuk
2022-02-08 11:20 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 19/27] meson: drop --with-win-sdk Paolo Bonzini
2022-02-03 17:33 ` [PATCH 20/27] qga/vss-win32: use widl if available Paolo Bonzini
2022-02-08 11:14 ` Konstantin Kostiuk
2022-02-08 11:20 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 21/27] qga/vss: use standard windows headers location Paolo Bonzini
2022-02-04 5:16 ` Philippe Mathieu-Daudé via
2022-02-08 11:21 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 22/27] configure, meson: replace VSS SDK checks and options with --enable-vss-sdk Paolo Bonzini
2022-02-03 18:07 ` Marc-André Lureau
2022-02-03 17:33 ` [PATCH 23/27] meson: do not make qga/vss-win32/meson.build conditional on C++ presence Paolo Bonzini
2022-02-08 11:14 ` Konstantin Kostiuk
2022-02-08 11:20 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 24/27] qga/vss-win32: require widl/midl, remove pre-built TLB file Paolo Bonzini
2022-02-04 5:18 ` Philippe Mathieu-Daudé via
2022-02-08 11:21 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 25/27] meson: require dynamic linking for VSS support Paolo Bonzini
2022-02-04 5:19 ` Philippe Mathieu-Daudé via
2022-02-08 11:23 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 26/27] meson, configure: move ntddscsi API check to meson Paolo Bonzini
2022-02-08 11:15 ` Konstantin Kostiuk
2022-02-08 11:20 ` Konstantin Kostiuk
2022-02-03 17:33 ` [PATCH 27/27] configure, meson: move CONFIG_IASL to a Meson option Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203173359.292068-19-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).