From: Igor Mammedov <imammedo@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ani Sinha <ani@anisinha.ca>,
gsomlo@gmail.com, qemu-devel@nongnu.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] hw/smbios: fix memory corruption for large guests due to handle overlap
Date: Fri, 4 Feb 2022 13:18:05 +0100 [thread overview]
Message-ID: <20220204131805.3a225566@redhat.com> (raw)
In-Reply-To: <20220204110558.h3246jyelrvhto5q@sirius.home.kraxel.org>
On Fri, 4 Feb 2022 12:05:58 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> > Another question is why we split memory on 16Gb chunks, to begin with.
> > Maybe instead of doing so, we should just add 1 type17 entry describing
> > whole system RAM size. In which case we don't need this dance around
> > handle offsets anymore.
>
> Maybe to make the entries look like they do on physical hardware?
> i.e. DIMM size is a power of two? Also physical 1TB DIMMs just
> don't exist?
Does it have to be a DIMM, we can make it Other/Unknown/Row of chips/Chip
to more close to builtin memory that's is our main ram is.
next prev parent reply other threads:[~2022-02-04 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 13:09 [PATCH v2] hw/smbios: fix memory corruption for large guests due to handle overlap Ani Sinha
2022-02-04 9:34 ` Igor Mammedov
2022-02-04 11:05 ` Gerd Hoffmann
2022-02-04 12:18 ` Igor Mammedov [this message]
2022-02-04 13:52 ` Ani Sinha
2022-02-10 12:32 ` Ani Sinha
2022-02-04 13:51 ` Michael S. Tsirkin
2022-02-07 15:12 ` Ani Sinha
2022-02-08 7:48 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204131805.3a225566@redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=gsomlo@gmail.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).