From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: Bernhard Beschow <shentey@gmail.com>
Subject: [PATCH 0/2] Make mc146818rtc more self-contained
Date: Sat, 5 Feb 2022 18:59:11 +0100 [thread overview]
Message-ID: <20220205175913.31738-1-shentey@gmail.com> (raw)
The internal state of mc146818rtc is currently exported as RTCState. This
violates encapsulation. Resolve it by first converting the last external user,
then by unexporting RTCState.
Bernhard Beschow (2):
isa/piix4: Resolve RTCState attribute
mc146818rtc: Unexport RTCState
hw/isa/piix4.c | 15 +--------------
hw/rtc/mc146818rtc.c | 34 ++++++++++++++++++++++++++++++++++
include/hw/rtc/mc146818rtc.h | 35 +----------------------------------
3 files changed, 36 insertions(+), 48 deletions(-)
--
2.35.1
next reply other threads:[~2022-02-05 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 17:59 Bernhard Beschow [this message]
2022-02-05 17:59 ` [PATCH 1/2] isa/piix4: Resolve RTCState attribute Bernhard Beschow
2022-02-05 18:53 ` Peter Maydell
2022-02-05 22:59 ` Philippe Mathieu-Daudé via
2022-02-05 17:59 ` [PATCH 2/2] mc146818rtc: Unexport RTCState Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220205175913.31738-1-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).