qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Will Cohen <wwcohen@gmail.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Fabian Franz <fabianfranz.oss@gmail.com>,
	Christian Schoenebeck <qemu_oss@crudebyte.com>,
	Greg Kurz <groug@kaod.org>,
	hi@alyssa.is, Will Cohen <wwcohen@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v4 11/11] 9p: darwin: Adjust assumption on virtio-9p-test
Date: Sun,  6 Feb 2022 15:07:19 -0500	[thread overview]
Message-ID: <20220206200719.74464-12-wwcohen@gmail.com> (raw)
In-Reply-To: <20220206200719.74464-1-wwcohen@gmail.com>

The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR
and AT_REMOVEDIR have the same value.

While this is true on Linux, it is not true everywhere, and leads to an
incorrect test failure on unlink_at, noticed when adding 9p to darwin:

Received response 7 (RLERROR) instead of 77 (RUNLINKAT)
Rlerror has errno 22 (Invalid argument)
**

ERROR:../tests/qtest/virtio-9p-test.c:305:v9fs_req_recv: assertion
failed (hdr.id == id): (7 == 77) Bail out!

ERROR:../tests/qtest/virtio-9p-test.c:305:v9fs_req_recv: assertion
failed (hdr.id == id): (7 == 77)

Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - Add explanation of patch and description
               of pre-patch test failure]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
---
 tests/qtest/virtio-9p-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index 41fed41de1..6bcf89f0f8 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b/tests/qtest/virtio-9p-test.c
@@ -1270,7 +1270,7 @@ static void fs_unlinkat_dir(void *obj, void *data, QGuestAllocator *t_alloc)
     /* ... and is actually a directory */
     g_assert((st.st_mode & S_IFMT) == S_IFDIR);
 
-    do_unlinkat(v9p, "/", "02", AT_REMOVEDIR);
+    do_unlinkat(v9p, "/", "02", P9_DOTL_AT_REMOVEDIR);
     /* directory should be gone now */
     g_assert(stat(new_dir, &st) != 0);
 
-- 
2.32.0 (Apple Git-132)



  parent reply	other threads:[~2022-02-06 20:22 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 20:07 [PATCH v4 00/11] 9p: Add support for darwin Will Cohen
2022-02-06 20:07 ` [PATCH v4 01/11] 9p: linux: Fix a couple Linux assumptions Will Cohen
2022-02-06 21:15   ` Philippe Mathieu-Daudé via
2022-02-07  8:03   ` Greg Kurz
2022-02-06 20:07 ` [PATCH v4 02/11] 9p: Rename 9p-util -> 9p-util-linux Will Cohen
2022-02-06 21:16   ` Philippe Mathieu-Daudé via
2022-02-06 20:07 ` [PATCH v4 03/11] 9p: darwin: Handle struct stat(fs) differences Will Cohen
2022-02-06 20:07 ` [PATCH v4 04/11] 9p: darwin: Handle struct dirent differences Will Cohen
2022-02-07  9:53   ` Fabian Franz
2022-02-07 13:52     ` Will Cohen
2022-02-07 17:05       ` Christian Schoenebeck
2022-02-07 14:41   ` Christian Schoenebeck
2022-02-07 16:41     ` Will Cohen
2022-02-06 20:07 ` [PATCH v4 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT} Will Cohen
2022-02-06 20:07 ` [PATCH v4 06/11] 9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX Will Cohen
2022-02-06 20:07 ` [PATCH v4 07/11] 9p: darwin: *xattr_nofollow implementations Will Cohen
2022-02-06 20:07 ` [PATCH v4 08/11] 9p: darwin: Compatibility for f/l*xattr Will Cohen
2022-02-06 20:07 ` [PATCH v4 09/11] 9p: darwin: Implement compatibility for mknodat Will Cohen
2022-02-06 21:20   ` Philippe Mathieu-Daudé via
2022-02-07  1:10     ` Will Cohen
2022-02-07  8:47       ` Greg Kurz
2022-02-07 10:30         ` Philippe Mathieu-Daudé via
2022-02-07 10:49           ` Greg Kurz
2022-02-07 10:57             ` Dr. David Alan Gilbert
2022-02-07 14:21               ` Christian Schoenebeck
2022-02-07 21:07                 ` Will Cohen
2022-02-07 22:37                   ` Will Cohen
2022-02-07 22:47                   ` Christian Schoenebeck
2022-02-07 22:55                     ` Will Cohen
2022-02-07 15:52             ` Vivek Goyal
2022-02-06 20:07 ` [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin Will Cohen
2022-02-06 21:22   ` Philippe Mathieu-Daudé via
2022-02-07  1:05     ` Will Cohen
2022-02-07 14:15       ` Christian Schoenebeck
2022-02-07 14:18         ` Will Cohen
2022-02-07 14:39         ` Greg Kurz
2022-02-07 16:04           ` Christian Schoenebeck
2022-02-07 14:27   ` Christian Schoenebeck
2022-02-07 14:37     ` Will Cohen
2022-02-07 15:38       ` Christian Schoenebeck
2022-02-06 20:07 ` Will Cohen [this message]
2022-02-07  6:15   ` [PATCH v4 11/11] 9p: darwin: Adjust assumption on virtio-9p-test Thomas Huth
2022-02-07 14:47 ` [PATCH v4 00/11] 9p: Add support for darwin Christian Schoenebeck
2022-02-07 14:56   ` Will Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220206200719.74464-12-wwcohen@gmail.com \
    --to=wwcohen@gmail.com \
    --cc=fabianfranz.oss@gmail.com \
    --cc=groug@kaod.org \
    --cc=hi@alyssa.is \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).