From: Alex Williamson <alex.williamson@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Eric Auger" <eric.auger@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PULL 0/2] VFIO fixes 2022-02-03
Date: Mon, 7 Feb 2022 08:50:45 -0700 [thread overview]
Message-ID: <20220207085045.1de46df1.alex.williamson@redhat.com> (raw)
In-Reply-To: <CAFEAcA-CX6hPOEEr_Yjcd1=4AHfkYgnkQ_ruUJ4mFwBYz1fLQA@mail.gmail.com>
On Sat, 5 Feb 2022 10:49:35 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
> >
> > The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
> >
> > Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
> >
> > are available in the Git repository at:
> >
> > git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
> >
> > for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
> >
> > hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
> >
> > ----------------------------------------------------------------
> > VFIO fixes 2022-02-03
> >
> > * Fix alignment warnings when using TPM CRB with vfio-pci devices
> > (Eric Auger & Philippe Mathieu-Daudé)
>
> Hi; this has a format-string issue that means it doesn't build
> on 32-bit systems:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>
> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> 'int'} [-Werror=format=]
> error_report("%s received unaligned region %s iova=0x%"PRIx64
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../hw/vfio/common.c:899:26:
> qemu_real_host_page_mask);
> ~~~~~~~~~~~~~~~~~~~~~~~~
>
> For intptr_t you want PRIxPTR.
Darn. Well, let me use this opportunity to ask, how are folks doing
32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
purpose, but I was eventually no longer able to maintain the build
dependencies. Looks like this failed on a mipsel cross build, but I
don't see such a cross compiler in Fedora. I do mingw32/64 cross
builds, but they leave a lot to be desired for code coverage. Thanks,
Alex
next prev parent reply other threads:[~2022-02-07 15:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 22:35 [PULL 0/2] VFIO fixes 2022-02-03 Alex Williamson
2022-02-03 22:35 ` [PULL 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region Alex Williamson
2022-02-04 12:08 ` Igor Mammedov
2022-02-07 9:23 ` Eric Auger
2022-02-07 13:42 ` Eric Auger
2022-02-23 13:02 ` Dr. David Alan Gilbert
2022-02-03 22:36 ` [PULL 2/2] hw/vfio/common: Silence ram device offset alignment error traces Alex Williamson
2022-02-05 10:49 ` [PULL 0/2] VFIO fixes 2022-02-03 Peter Maydell
2022-02-05 11:19 ` Philippe Mathieu-Daudé via
2022-02-07 9:10 ` Eric Auger
2022-02-07 15:50 ` Alex Williamson [this message]
2022-02-07 16:08 ` Philippe Mathieu-Daudé via
2022-02-07 16:54 ` Alex Williamson
2022-02-07 17:47 ` Alex Williamson
2022-02-07 16:20 ` Thomas Huth
2022-06-02 21:31 ` Alex Williamson
2022-06-02 22:15 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207085045.1de46df1.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=eric.auger@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).