From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH] block/vvfat: Fix memleaks in vvfat_close()
Date: Mon, 7 Feb 2022 12:37:16 +0100 [thread overview]
Message-ID: <20220207113716.31400-1-hreitz@redhat.com> (raw)
qcow_filename and used_clusters are allocated in enable_write_target(),
but freed only in the error path of vvfat_open(). Free them in
vvfat_close(), too.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
block/vvfat.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/vvfat.c b/block/vvfat.c
index b2b58d93b8..811ba76e30 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -3213,6 +3213,8 @@ static void vvfat_close(BlockDriverState *bs)
array_free(&(s->directory));
array_free(&(s->mapping));
g_free(s->cluster_buffer);
+ g_free(s->qcow_filename);
+ g_free(s->used_clusters);
if (s->qcow) {
migrate_del_blocker(s->migration_blocker);
--
2.34.1
next reply other threads:[~2022-02-07 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 11:37 Hanna Reitz [this message]
2022-02-07 15:20 ` [PATCH] block/vvfat: Fix memleaks in vvfat_close() Philippe Mathieu-Daudé via
2022-02-07 16:36 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207113716.31400-1-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).