qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [PATCH v6 6/8] tcg/sparc: Use the constant pool for 64-bit constants
Date: Tue,  8 Feb 2022 18:17:08 +1100	[thread overview]
Message-ID: <20220208071710.320122-7-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220208071710.320122-1-richard.henderson@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/sparc/tcg-target.c.inc | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc
index ae809c9941..21b0dd6734 100644
--- a/tcg/sparc/tcg-target.c.inc
+++ b/tcg/sparc/tcg-target.c.inc
@@ -336,6 +336,13 @@ static bool patch_reloc(tcg_insn_unit *src_rw, int type,
         insn &= ~INSN_OFF19(-1);
         insn |= INSN_OFF19(pcrel);
         break;
+    case R_SPARC_13:
+        if (!check_fit_ptr(value, 13)) {
+            return false;
+        }
+        insn &= ~INSN_IMM13(-1);
+        insn |= INSN_IMM13(value);
+        break;
     default:
         g_assert_not_reached();
     }
@@ -479,6 +486,14 @@ static void tcg_out_movi_int(TCGContext *s, TCGType type, TCGReg ret,
         return;
     }
 
+    /* Use the constant pool, if possible. */
+    if (!in_prologue && USE_REG_TB) {
+        new_pool_label(s, arg, R_SPARC_13, s->code_ptr,
+                       tcg_tbrel_diff(s, NULL));
+        tcg_out32(s, LDX | INSN_RD(ret) | INSN_RS1(TCG_REG_TB));
+        return;
+    }
+
     /* A 64-bit constant decomposed into 2 32-bit pieces.  */
     if (check_fit_i32(lo, 13)) {
         hi = (arg - lo) >> 32;
-- 
2.25.1



  parent reply	other threads:[~2022-02-08  8:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08  7:17 [PATCH v6 0/8] tcg/sparc: Unaligned access for user-only Richard Henderson
2022-02-08  7:17 ` [PATCH v6 1/8] tcg/sparc: Use tcg_out_movi_imm13 in tcg_out_addsub2_i64 Richard Henderson
2022-02-08 10:40   ` Peter Maydell
2022-02-08 11:09     ` Richard Henderson
2022-02-08 11:16       ` Peter Maydell
2022-02-08  7:17 ` [PATCH v6 2/8] tcg/sparc: Split out tcg_out_movi_imm32 Richard Henderson
2022-02-08 10:44   ` Peter Maydell
2022-02-08  7:17 ` [PATCH v6 3/8] tcg/sparc: Add scratch argument to tcg_out_movi_int Richard Henderson
2022-02-08 10:51   ` Peter Maydell
2022-02-08  7:17 ` [PATCH v6 4/8] tcg/sparc: Improve code gen for shifted 32-bit constants Richard Henderson
2022-02-08  7:17 ` [PATCH v6 5/8] tcg/sparc: Convert patch_reloc to return bool Richard Henderson
2022-02-08 10:46   ` Philippe Mathieu-Daudé via
2022-02-08  7:17 ` Richard Henderson [this message]
2022-02-08  7:17 ` [PATCH v6 7/8] tcg/sparc: Add tcg_out_jmpl_const for better tail calls Richard Henderson
2022-02-08  7:17 ` [PATCH v6 8/8] tcg/sparc: Support unaligned access for user-only Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208071710.320122-7-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).