* [RFC PATCH] include/exec: fix softmmu version of TARGET_ABI_FMT_lx
@ 2022-02-08 12:59 Alex Bennée
2022-02-08 15:51 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2022-02-08 12:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Alex Bennée, Paolo Bonzini
TARGET_ABI_FMT_lx isn't available for softmmu which causes confusion
when trying to print. As abi_ptr == target_ulong use its format string
instead.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
include/exec/cpu_ldst.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
index a878fd0105..da987fe8ad 100644
--- a/include/exec/cpu_ldst.h
+++ b/include/exec/cpu_ldst.h
@@ -121,7 +121,7 @@ static inline bool guest_range_valid_untagged(abi_ulong start, abi_ulong len)
})
#else
typedef target_ulong abi_ptr;
-#define TARGET_ABI_FMT_ptr TARGET_ABI_FMT_lx
+#define TARGET_ABI_FMT_ptr TARGET_FMT_lx
#endif
uint32_t cpu_ldub_data(CPUArchState *env, abi_ptr ptr);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] include/exec: fix softmmu version of TARGET_ABI_FMT_lx
2022-02-08 12:59 [RFC PATCH] include/exec: fix softmmu version of TARGET_ABI_FMT_lx Alex Bennée
@ 2022-02-08 15:51 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2022-02-08 15:51 UTC (permalink / raw)
To: Alex Bennée; +Cc: Paolo Bonzini, Richard Henderson, qemu-devel
On Tue, 8 Feb 2022 at 15:42, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> TARGET_ABI_FMT_lx isn't available for softmmu which causes confusion
> when trying to print. As abi_ptr == target_ulong use its format string
> instead.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> include/exec/cpu_ldst.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
> index a878fd0105..da987fe8ad 100644
> --- a/include/exec/cpu_ldst.h
> +++ b/include/exec/cpu_ldst.h
> @@ -121,7 +121,7 @@ static inline bool guest_range_valid_untagged(abi_ulong start, abi_ulong len)
> })
> #else
> typedef target_ulong abi_ptr;
> -#define TARGET_ABI_FMT_ptr TARGET_ABI_FMT_lx
> +#define TARGET_ABI_FMT_ptr TARGET_FMT_lx
> #endif
>
> uint32_t cpu_ldub_data(CPUArchState *env, abi_ptr ptr);
I think this was clearly just a bug that we never noticed because
we haven't tried using TARGET_ABI_FMT_ptr in softmmu code before.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
I do still wonder whether the softmmu code in question really
ought to be using abi_ptr, though.
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-08 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08 12:59 [RFC PATCH] include/exec: fix softmmu version of TARGET_ABI_FMT_lx Alex Bennée
2022-02-08 15:51 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).