From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B85AC433EF for ; Tue, 8 Feb 2022 16:22:46 +0000 (UTC) Received: from localhost ([::1]:38962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHTGP-0008Hn-Kg for qemu-devel@archiver.kernel.org; Tue, 08 Feb 2022 11:22:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHQqG-0007gh-Gl for qemu-devel@nongnu.org; Tue, 08 Feb 2022 08:47:44 -0500 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:25016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHQqD-0007FC-Df for qemu-devel@nongnu.org; Tue, 08 Feb 2022 08:47:35 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-467-LxKEIm-gPpqfx5l5XKzyvw-1; Tue, 08 Feb 2022 08:47:28 -0500 X-MC-Unique: LxKEIm-gPpqfx5l5XKzyvw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B657C83DD21; Tue, 8 Feb 2022 13:47:27 +0000 (UTC) Received: from bahia (unknown [10.39.193.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 691478049E; Tue, 8 Feb 2022 13:47:20 +0000 (UTC) Date: Tue, 8 Feb 2022 14:47:19 +0100 From: Greg Kurz To: Miroslav Rezanina Subject: Re: [PATCH v2] Use long endian options for ppc64 Message-ID: <20220208144719.1ea88910@bahia> In-Reply-To: <20220131091714.4825-1-mrezanin@redhat.com> References: <20220131091714.4825-1-mrezanin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=207.211.30.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 31 Jan 2022 10:17:14 +0100 Miroslav Rezanina wrote: > GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are > equivalent on ppc64 architecture. However, Clang supports only long > version of the options. >=20 > Use longer form in configure to properly support both GCC and Clang > compiler. In addition, fix this issue in tcg test configure. >=20 > Signed-off-by: Miroslav Rezanina >=20 > --- Reviewed-by: Greg Kurz > This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc6= 4. >=20 > v2: > - handle both -mlittle and -mbig usage > - fix tests/tcg/configure.sh > --- > configure | 4 ++-- > tests/tcg/configure.sh | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/configure b/configure > index e6cfc0e4be..066fa29b70 100755 > --- a/configure > +++ b/configure > @@ -655,10 +655,10 @@ case "$cpu" in > ppc) > CPU_CFLAGS=3D"-m32" ;; > ppc64) > - CPU_CFLAGS=3D"-m64 -mbig" ;; > + CPU_CFLAGS=3D"-m64 -mbig-endian" ;; > ppc64le) > cpu=3D"ppc64" > - CPU_CFLAGS=3D"-m64 -mlittle" ;; > + CPU_CFLAGS=3D"-m64 -mlittle-endian" ;; > =20 > s390) > CPU_CFLAGS=3D"-m31" ;; > diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh > index 309335a2bd..21959e1fde 100755 > --- a/tests/tcg/configure.sh > +++ b/tests/tcg/configure.sh > @@ -64,9 +64,9 @@ fi > : ${cross_cc_ppc=3D"powerpc-linux-gnu-gcc"} > : ${cross_cc_cflags_ppc=3D"-m32"} > : ${cross_cc_ppc64=3D"powerpc64-linux-gnu-gcc"} > -: ${cross_cc_cflags_ppc64=3D"-m64 -mbig"} > +: ${cross_cc_cflags_ppc64=3D"-m64 -mbig-endian"} > : ${cross_cc_ppc64le=3D"$cross_cc_ppc64"} > -: ${cross_cc_cflags_ppc64le=3D"-m64 -mlittle"} > +: ${cross_cc_cflags_ppc64le=3D"-m64 -mlittle-endian"} > : ${cross_cc_riscv64=3D"riscv64-linux-gnu-gcc"} > : ${cross_cc_s390x=3D"s390x-linux-gnu-gcc"} > : ${cross_cc_sh4=3D"sh4-linux-gnu-gcc"}