From: Greg Kurz <groug@kaod.org>
To: Miroslav Rezanina <mrezanin@redhat.com>
Cc: richard.henderson@linaro.org, qemu-devel@nongnu.org,
f4bug@amsat.org, qemu-ppc@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>,
pbonzini@redhat.com
Subject: Re: [PATCH v2] Use long endian options for ppc64
Date: Wed, 9 Feb 2022 10:24:50 +0100 [thread overview]
Message-ID: <20220209102450.7fd3dfef@bahia> (raw)
In-Reply-To: <20220208144719.1ea88910@bahia>
On Tue, 8 Feb 2022 14:47:19 +0100
Greg Kurz <groug@kaod.org> wrote:
> On Mon, 31 Jan 2022 10:17:14 +0100
> Miroslav Rezanina <mrezanin@redhat.com> wrote:
>
> > GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are
> > equivalent on ppc64 architecture. However, Clang supports only long
> > version of the options.
> >
> > Use longer form in configure to properly support both GCC and Clang
> > compiler. In addition, fix this issue in tcg test configure.
> >
> > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> >
> > ---
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
>
Cc'ing QEMU PPC folks since they're likely the primary users
of ppc64 hosts.
> > This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.
> >
> > v2:
> > - handle both -mlittle and -mbig usage
> > - fix tests/tcg/configure.sh
> > ---
> > configure | 4 ++--
> > tests/tcg/configure.sh | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/configure b/configure
> > index e6cfc0e4be..066fa29b70 100755
> > --- a/configure
> > +++ b/configure
> > @@ -655,10 +655,10 @@ case "$cpu" in
> > ppc)
> > CPU_CFLAGS="-m32" ;;
> > ppc64)
> > - CPU_CFLAGS="-m64 -mbig" ;;
> > + CPU_CFLAGS="-m64 -mbig-endian" ;;
> > ppc64le)
> > cpu="ppc64"
> > - CPU_CFLAGS="-m64 -mlittle" ;;
> > + CPU_CFLAGS="-m64 -mlittle-endian" ;;
> >
> > s390)
> > CPU_CFLAGS="-m31" ;;
> > diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> > index 309335a2bd..21959e1fde 100755
> > --- a/tests/tcg/configure.sh
> > +++ b/tests/tcg/configure.sh
> > @@ -64,9 +64,9 @@ fi
> > : ${cross_cc_ppc="powerpc-linux-gnu-gcc"}
> > : ${cross_cc_cflags_ppc="-m32"}
> > : ${cross_cc_ppc64="powerpc64-linux-gnu-gcc"}
> > -: ${cross_cc_cflags_ppc64="-m64 -mbig"}
> > +: ${cross_cc_cflags_ppc64="-m64 -mbig-endian"}
> > : ${cross_cc_ppc64le="$cross_cc_ppc64"}
> > -: ${cross_cc_cflags_ppc64le="-m64 -mlittle"}
> > +: ${cross_cc_cflags_ppc64le="-m64 -mlittle-endian"}
> > : ${cross_cc_riscv64="riscv64-linux-gnu-gcc"}
> > : ${cross_cc_s390x="s390x-linux-gnu-gcc"}
> > : ${cross_cc_sh4="sh4-linux-gnu-gcc"}
>
next prev parent reply other threads:[~2022-02-09 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 9:17 [PATCH v2] Use long endian options for ppc64 Miroslav Rezanina
2022-02-01 0:00 ` Philippe Mathieu-Daudé via
2022-02-08 13:47 ` Greg Kurz
2022-02-09 9:24 ` Greg Kurz [this message]
2022-02-08 20:57 ` Matheus K. Ferst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209102450.7fd3dfef@bahia \
--to=groug@kaod.org \
--cc=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=mrezanin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).