From: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH 0/6] ui/dbus: Share one listener for a console
Date: Sun, 13 Feb 2022 11:42:16 +0900 [thread overview]
Message-ID: <20220213024222.3548-1-akihiko.odaki@gmail.com> (raw)
ui/dbus required to have multiple DisplayChangeListeners (possibly with OpenGL)
for a console but that caused several problems:
- It broke egl-headless, an unusual display which implements OpenGL rendering
for non-OpenGL displays. The code to support multiple DisplayChangeListeners
does not consider the case where non-OpenGL displays listens OpenGL consoles.
- Multiple OpenGL DisplayChangeListeners of dbus shares one DisplaySurface and
modifies its texture field, causing OpenGL texture leak and use-after-free.
- Introduced extra code to check the compatibility of OpenGL context providers
and OpenGL texture renderers where those are often inherently tightly coupled
since they must share the same hardware.
- Needed extra work to broadcast the same change to multiple dbus listeners.
This series solve them by implementing the change broadcast in ui/dbus, which
knows exactly what is needed. Changes for the common code to support multiple
OpenGL DisplayChangeListeners were reverted to fix egl-headless and reduce
the code size.
Akihiko Odaki (6):
ui/dbus: Share one listener for a console
Revert "console: save current scanout details"
Revert "ui: split the GL context in a different object"
Revert "ui: dispatch GL events to all listeners"
Revert "ui: associate GL context outside of display listener
registration"
Revert "ui: factor out qemu_console_set_display_gl_ctx()"
include/ui/console.h | 60 +-----
include/ui/egl-context.h | 6 +-
include/ui/gtk.h | 11 +-
include/ui/sdl2.h | 7 +-
include/ui/spice-display.h | 1 -
ui/console.c | 258 +++++++----------------
ui/dbus-console.c | 109 ++--------
ui/dbus-listener.c | 417 +++++++++++++++++++++++++++----------
ui/dbus.c | 22 --
ui/dbus.h | 36 +++-
ui/egl-context.c | 6 +-
ui/egl-headless.c | 20 +-
ui/gtk-egl.c | 10 +-
ui/gtk-gl-area.c | 8 +-
ui/gtk.c | 25 +--
ui/sdl2-gl.c | 10 +-
ui/sdl2.c | 14 +-
ui/spice-display.c | 19 +-
18 files changed, 498 insertions(+), 541 deletions(-)
--
2.32.0 (Apple Git-132)
next reply other threads:[~2022-02-13 2:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 2:42 Akihiko Odaki [this message]
2022-02-13 2:42 ` [PATCH 1/6] ui/dbus: Share one listener for a console Akihiko Odaki
2022-02-13 2:42 ` [PATCH 2/6] Revert "console: save current scanout details" Akihiko Odaki
2022-02-13 2:42 ` [PATCH 3/6] Revert "ui: split the GL context in a different object" Akihiko Odaki
2022-02-13 2:42 ` [PATCH 4/6] Revert "ui: dispatch GL events to all listeners" Akihiko Odaki
2022-02-13 2:42 ` [PATCH 5/6] Revert "ui: associate GL context outside of display listener registration" Akihiko Odaki
2022-02-13 2:42 ` [PATCH 6/6] Revert "ui: factor out qemu_console_set_display_gl_ctx()" Akihiko Odaki
2022-02-14 12:06 ` [PATCH 0/6] ui/dbus: Share one listener for a console Marc-André Lureau
2022-02-14 13:15 ` Akihiko Odaki
2022-02-14 19:49 ` Marc-André Lureau
2022-02-15 3:08 ` Akihiko Odaki
2022-02-15 13:32 ` Marc-André Lureau
[not found] ` <CAMVc7JWnqucqKeEBDWFES8JYY77gmbMaX-inz+CSzd-bymr5cQ@mail.gmail.com>
[not found] ` <CAJ+F1CJ1ZZV-dv6kHhYmAkg5Pnrb_-q7o3Bndo6cQZsYN+RkgA@mail.gmail.com>
2022-02-16 17:05 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220213024222.3548-1-akihiko.odaki@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).