From: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH 4/6] Revert "ui: dispatch GL events to all listeners"
Date: Sun, 13 Feb 2022 11:42:20 +0900 [thread overview]
Message-ID: <20220213024222.3548-5-akihiko.odaki@gmail.com> (raw)
In-Reply-To: <20220213024222.3548-1-akihiko.odaki@gmail.com>
This reverts commit 7cc712e9862ffdbe4161dbdf3bbf41bcbe547472.
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
ui/console.c | 58 +++++++++++++++-------------------------------------
1 file changed, 16 insertions(+), 42 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index 13c0d001c09..6f21007737e 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1824,12 +1824,8 @@ int dpy_gl_ctx_make_current(QemuConsole *con, QEMUGLContext ctx)
void dpy_gl_scanout_disable(QemuConsole *con)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
-
- QLIST_FOREACH(dcl, &s->listeners, next) {
- dcl->ops->dpy_gl_scanout_disable(dcl);
- }
+ assert(con->gl);
+ con->gl->ops->dpy_gl_scanout_disable(con->gl);
}
void dpy_gl_scanout_texture(QemuConsole *con,
@@ -1840,80 +1836,58 @@ void dpy_gl_scanout_texture(QemuConsole *con,
uint32_t x, uint32_t y,
uint32_t width, uint32_t height)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
-
- QLIST_FOREACH(dcl, &s->listeners, next) {
- dcl->ops->dpy_gl_scanout_texture(dcl, backing_id,
+ assert(con->gl);
+ con->gl->ops->dpy_gl_scanout_texture(con->gl, backing_id,
backing_y_0_top,
backing_width, backing_height,
x, y, width, height);
- }
}
void dpy_gl_scanout_dmabuf(QemuConsole *con,
QemuDmaBuf *dmabuf)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
-
- QLIST_FOREACH(dcl, &s->listeners, next) {
- dcl->ops->dpy_gl_scanout_dmabuf(dcl, dmabuf);
- }
+ assert(con->gl);
+ con->gl->ops->dpy_gl_scanout_dmabuf(con->gl, dmabuf);
}
void dpy_gl_cursor_dmabuf(QemuConsole *con, QemuDmaBuf *dmabuf,
bool have_hot, uint32_t hot_x, uint32_t hot_y)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
+ assert(con->gl);
- QLIST_FOREACH(dcl, &s->listeners, next) {
- if (dcl->ops->dpy_gl_cursor_dmabuf) {
- dcl->ops->dpy_gl_cursor_dmabuf(dcl, dmabuf,
+ if (con->gl->ops->dpy_gl_cursor_dmabuf) {
+ con->gl->ops->dpy_gl_cursor_dmabuf(con->gl, dmabuf,
have_hot, hot_x, hot_y);
- }
}
}
void dpy_gl_cursor_position(QemuConsole *con,
uint32_t pos_x, uint32_t pos_y)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
+ assert(con->gl);
- QLIST_FOREACH(dcl, &s->listeners, next) {
- if (dcl->ops->dpy_gl_cursor_position) {
- dcl->ops->dpy_gl_cursor_position(dcl, pos_x, pos_y);
- }
+ if (con->gl->ops->dpy_gl_cursor_position) {
+ con->gl->ops->dpy_gl_cursor_position(con->gl, pos_x, pos_y);
}
}
void dpy_gl_release_dmabuf(QemuConsole *con,
QemuDmaBuf *dmabuf)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
+ assert(con->gl);
- QLIST_FOREACH(dcl, &s->listeners, next) {
- if (dcl->ops->dpy_gl_release_dmabuf) {
- dcl->ops->dpy_gl_release_dmabuf(dcl, dmabuf);
- }
+ if (con->gl->ops->dpy_gl_release_dmabuf) {
+ con->gl->ops->dpy_gl_release_dmabuf(con->gl, dmabuf);
}
}
void dpy_gl_update(QemuConsole *con,
uint32_t x, uint32_t y, uint32_t w, uint32_t h)
{
- DisplayState *s = con->ds;
- DisplayChangeListener *dcl;
-
assert(con->gl);
graphic_hw_gl_block(con, true);
- QLIST_FOREACH(dcl, &s->listeners, next) {
- dcl->ops->dpy_gl_update(dcl, x, y, w, h);
- }
+ con->gl->ops->dpy_gl_update(con->gl, x, y, w, h);
graphic_hw_gl_block(con, false);
}
--
2.32.0 (Apple Git-132)
next prev parent reply other threads:[~2022-02-13 2:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 2:42 [PATCH 0/6] ui/dbus: Share one listener for a console Akihiko Odaki
2022-02-13 2:42 ` [PATCH 1/6] " Akihiko Odaki
2022-02-13 2:42 ` [PATCH 2/6] Revert "console: save current scanout details" Akihiko Odaki
2022-02-13 2:42 ` [PATCH 3/6] Revert "ui: split the GL context in a different object" Akihiko Odaki
2022-02-13 2:42 ` Akihiko Odaki [this message]
2022-02-13 2:42 ` [PATCH 5/6] Revert "ui: associate GL context outside of display listener registration" Akihiko Odaki
2022-02-13 2:42 ` [PATCH 6/6] Revert "ui: factor out qemu_console_set_display_gl_ctx()" Akihiko Odaki
2022-02-14 12:06 ` [PATCH 0/6] ui/dbus: Share one listener for a console Marc-André Lureau
2022-02-14 13:15 ` Akihiko Odaki
2022-02-14 19:49 ` Marc-André Lureau
2022-02-15 3:08 ` Akihiko Odaki
2022-02-15 13:32 ` Marc-André Lureau
[not found] ` <CAMVc7JWnqucqKeEBDWFES8JYY77gmbMaX-inz+CSzd-bymr5cQ@mail.gmail.com>
[not found] ` <CAJ+F1CJ1ZZV-dv6kHhYmAkg5Pnrb_-q7o3Bndo6cQZsYN+RkgA@mail.gmail.com>
2022-02-16 17:05 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220213024222.3548-5-akihiko.odaki@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).