qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gautam Dawar <gautam.dawar@xilinx.com>
To: <mst@redhat.com>, <jasowang@redhat.com>, <qemu-devel@nongnu.org>,
	<eperezma@redhat.com>
Cc: martinh@xilinx.com, pabloc@xilinx.com, hanand@xilinx.com,
	tanujk@xilinx.com, gdawar@xilinx.com
Subject: [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices
Date: Tue, 15 Feb 2022 12:52:31 +0530	[thread overview]
Message-ID: <20220215072231.2498-3-gdawar@xilinx.com> (raw)
In-Reply-To: <20220215072231.2498-1-gdawar@xilinx.com>

This patch adds the ability to negotiate VIRTIO_F_IN_ORDER bit
for vhost-vdpa backend when the underlying device supports this
feature.
This would aid in reaping performance benefits with HW devices
that implement this feature. At the same time, it shouldn't have
any negative impact as vhost-vdpa backend doesn't involve any
userspace virtqueue operations.

Signed-off-by: Gautam Dawar <gdawar@xilinx.com>
---
 hw/net/virtio-net.c | 10 ++++++++++
 net/vhost-vdpa.c    |  1 +
 2 files changed, 11 insertions(+)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index cf8ab0f8af..a1089d06f6 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3507,11 +3507,21 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp)
     nc->rxfilter_notify_enabled = 1;
 
    if (nc->peer && nc->peer->info->type == NET_CLIENT_DRIVER_VHOST_VDPA) {
+        uint64_t features = BIT_ULL(VIRTIO_F_IN_ORDER);
         struct virtio_net_config netcfg = {};
+
         memcpy(&netcfg.mac, &n->nic_conf.macaddr, ETH_ALEN);
         vhost_net_set_config(get_vhost_net(nc->peer),
             (uint8_t *)&netcfg, 0, ETH_ALEN, VHOST_SET_CONFIG_TYPE_MASTER);
+
+	/*
+         * For vhost-vdpa, if underlying device supports IN_ORDER feature,
+         * make it available for negotiation.
+         */
+	features = vhost_net_get_features(get_vhost_net(nc->peer), features);
+	n->host_features |= features;
     }
+
     QTAILQ_INIT(&n->rsc_chains);
     n->qdev = dev;
 
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 25dd6dd975..2886cba5ec 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -62,6 +62,7 @@ const int vdpa_feature_bits[] = {
     VIRTIO_NET_F_CTRL_VQ,
     VIRTIO_F_IOMMU_PLATFORM,
     VIRTIO_F_RING_PACKED,
+    VIRTIO_F_IN_ORDER,
     VIRTIO_NET_F_RSS,
     VIRTIO_NET_F_HASH_REPORT,
     VIRTIO_NET_F_GUEST_ANNOUNCE,
-- 
2.30.1



  parent reply	other threads:[~2022-02-15 10:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15  7:22 [PATCH 0/2] Allow VIRTIO_F_IN_ORDER negotiation with vhost-vdpa Gautam Dawar
2022-02-15  7:22 ` [PATCH 1/2] linux headers: update against Linux 5.17-rc4 Gautam Dawar
2022-02-17  7:17   ` Jason Wang
2022-02-17  9:06     ` Gautam Dawar
2022-02-15  7:22 ` Gautam Dawar [this message]
2022-02-15 15:22   ` [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices Eugenio Perez Martin
2022-02-17  7:16   ` Jason Wang
2022-02-17  8:27     ` Gautam Dawar
2022-02-17  8:32       ` Michael S. Tsirkin
2022-02-17  8:54     ` Eugenio Perez Martin
2022-02-17  7:32   ` Michael S. Tsirkin
2022-02-17 14:29     ` Stefano Garzarella
2022-02-18 10:24       ` Eugenio Perez Martin
2022-02-18 16:57         ` Stefano Garzarella
2022-02-18 10:22     ` Eugenio Perez Martin
2022-02-21  4:31       ` Jason Wang
2022-02-18 11:09   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220215072231.2498-3-gdawar@xilinx.com \
    --to=gautam.dawar@xilinx.com \
    --cc=eperezma@redhat.com \
    --cc=gdawar@xilinx.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=martinh@xilinx.com \
    --cc=mst@redhat.com \
    --cc=pabloc@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tanujk@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).