From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: "Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings
Date: Tue, 15 Feb 2022 13:06:25 +0100 [thread overview]
Message-ID: <20220215120625.64711-5-f4bug@amsat.org> (raw)
In-Reply-To: <20220215120625.64711-1-f4bug@amsat.org>
We globally ignore the 'initializer overrides' warnings in C code
since commit c1556a812a ("configure: Disable (clang)
initializer-overrides warnings"). Unfortunately the ${gcc_flags}
variable is not propagated to Objective-C flags ($OBJCFLAGS).
Instead of reworking the configure script to test all supported
C flags in Objective-C and sanitize them, ignore the warning
locally with the GCC diagnostic #pragma (Clang ignores it).
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
ui/cocoa.m | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 30702d31a5..8956694447 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -638,6 +638,9 @@ QemuCocoaView *cocoaView;
qkbd_state_key_event(kbd, keycode, !qkbd_state_key_get(kbd, keycode));
}
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Winitializer-overrides"
+
// Does the work of sending input to the monitor
- (void) handleMonitorInput:(NSEvent *)event
{
@@ -702,6 +705,8 @@ QemuCocoaView *cocoaView;
}
}
+#pragma GCC diagnostic pop
+
- (bool) handleEvent:(NSEvent *)event
{
if(!allow_events) {
--
2.34.1
next prev parent reply other threads:[~2022-02-15 12:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 12:06 [RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS Philippe Mathieu-Daudé via
2022-02-15 12:06 ` [RFC PATCH 1/4] osdep: Avoid using Clang-specific __builtin_available() Philippe Mathieu-Daudé via
2022-02-15 12:06 ` [PATCH 2/4] osdep: Un-inline qemu_thread_jit_execute/write Philippe Mathieu-Daudé via
2022-02-15 13:09 ` Akihiko Odaki
2022-02-15 13:29 ` Philippe Mathieu-Daudé via
2022-02-15 12:06 ` [RFC PATCH 3/4] audio: Rename coreaudio extension to use Objective-C compiler Philippe Mathieu-Daudé via
2022-02-15 13:37 ` Christian Schoenebeck
2022-02-15 12:06 ` Philippe Mathieu-Daudé via [this message]
2022-02-15 12:34 ` [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings Peter Maydell
2022-02-15 13:19 ` Akihiko Odaki
2022-02-15 13:23 ` Philippe Mathieu-Daudé via
2022-02-15 13:18 ` Christian Schoenebeck
2022-02-15 13:45 ` Peter Maydell
2022-02-15 14:06 ` Philippe Mathieu-Daudé via
2022-02-15 14:11 ` Christian Schoenebeck
2022-02-15 14:17 ` Peter Maydell
2022-02-15 13:06 ` [RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS Akihiko Odaki
2022-02-15 13:25 ` Philippe Mathieu-Daudé via
2022-02-16 2:28 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215120625.64711-5-f4bug@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=akihiko.odaki@gmail.com \
--cc=f4bug@amsat.org \
--cc=qemu_oss@crudebyte.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).