* [PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro
@ 2022-02-15 15:31 Ani Sinha
2022-02-15 19:47 ` Eric DeVolder
0 siblings, 1 reply; 2+ messages in thread
From: Ani Sinha @ 2022-02-15 15:31 UTC (permalink / raw)
To: qemu-devel, Michael S. Tsirkin, Igor Mammedov, Ani Sinha; +Cc: Eric DeVolder
This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added
as a part of the ERST implementation seems to be unused. Remove it.
CC: Eric DeVolder <eric.devolder@oracle.com>
Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
hw/acpi/erst.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
index c0a23cf467..de509c2b48 100644
--- a/hw/acpi/erst.c
+++ b/hw/acpi/erst.c
@@ -80,11 +80,6 @@
#define UEFI_CPER_RECORD_MIN_SIZE 128U
#define UEFI_CPER_RECORD_LENGTH_OFFSET 20U
#define UEFI_CPER_RECORD_ID_OFFSET 96U
-#define IS_UEFI_CPER_RECORD(ptr) \
- (((ptr)[0] == 'C') && \
- ((ptr)[1] == 'P') && \
- ((ptr)[2] == 'E') && \
- ((ptr)[3] == 'R'))
/*
* NOTE that when accessing CPER fields within a record, memcpy()
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro
2022-02-15 15:31 [PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro Ani Sinha
@ 2022-02-15 19:47 ` Eric DeVolder
0 siblings, 0 replies; 2+ messages in thread
From: Eric DeVolder @ 2022-02-15 19:47 UTC (permalink / raw)
To: Ani Sinha, qemu-devel, Michael S. Tsirkin, Igor Mammedov
On 2/15/22 09:31, Ani Sinha wrote:
> This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added
> as a part of the ERST implementation seems to be unused. Remove it.
>
> CC: Eric DeVolder <eric.devolder@oracle.com>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
Thanks!
Reviewed-by: Eric DeVolder <eric.devolder@oracle.com>
> ---
> hw/acpi/erst.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
> index c0a23cf467..de509c2b48 100644
> --- a/hw/acpi/erst.c
> +++ b/hw/acpi/erst.c
> @@ -80,11 +80,6 @@
> #define UEFI_CPER_RECORD_MIN_SIZE 128U
> #define UEFI_CPER_RECORD_LENGTH_OFFSET 20U
> #define UEFI_CPER_RECORD_ID_OFFSET 96U
> -#define IS_UEFI_CPER_RECORD(ptr) \
> - (((ptr)[0] == 'C') && \
> - ((ptr)[1] == 'P') && \
> - ((ptr)[2] == 'E') && \
> - ((ptr)[3] == 'R'))
>
> /*
> * NOTE that when accessing CPER fields within a record, memcpy()
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-15 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-15 15:31 [PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro Ani Sinha
2022-02-15 19:47 ` Eric DeVolder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).