From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: "Roman Bolshakov" <r.bolshakov@yadro.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64
Date: Tue, 15 Feb 2022 18:01:02 +0100 [thread overview]
Message-ID: <20220215170106.95848-5-f4bug@amsat.org> (raw)
In-Reply-To: <20220215170106.95848-1-f4bug@amsat.org>
GCC 10.1 introduced the -moutline-atomics option on Aarch64.
This options is enabled by default, and triggers a link failure:
Undefined symbols for architecture arm64:
"___aarch64_cas1_acq_rel", referenced from:
_qmp_migrate_recover in migration_migration.c.o
_cpu_atomic_cmpxchgb_mmu in accel_tcg_cputlb.c.o
_cpu_atomic_fetch_sminb_mmu in accel_tcg_cputlb.c.o
_cpu_atomic_fetch_uminb_mmu in accel_tcg_cputlb.c.o
_cpu_atomic_fetch_smaxb_mmu in accel_tcg_cputlb.c.o
_cpu_atomic_fetch_umaxb_mmu in accel_tcg_cputlb.c.o
_cpu_atomic_smin_fetchb_mmu in accel_tcg_cputlb.c.o
...
"___aarch64_ldadd4_acq_rel", referenced from:
_multifd_recv_new_channel in migration_multifd.c.o
_monitor_event in monitor_hmp.c.o
_handle_hmp_command in monitor_hmp.c.o
_colo_compare_finalize in net_colo-compare.c.o
_flatview_unref in softmmu_memory.c.o
_virtio_scsi_hotunplug in hw_scsi_virtio-scsi.c.o
_tcg_register_thread in tcg_tcg.c.o
...
"___aarch64_swp4_acq", referenced from:
_qemu_spin_lock in softmmu_cpu-timers.c.o
_cpu_get_ticks in softmmu_cpu-timers.c.o
_qemu_spin_lock in softmmu_icount.c.o
_cpu_exec in accel_tcg_cpu-exec.c.o
_page_flush_tb_1.isra.0 in accel_tcg_translate-all.c.o
_page_entry_lock in accel_tcg_translate-all.c.o
_do_tb_phys_invalidate in accel_tcg_translate-all.c.o
...
QEMU implements its own atomic operations using C11 builtin helpers.
Disable the GCC out-of-line atomic ops.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Clearly out of my understanding, but at least it links and the qtests
pass.
---
configure | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/configure b/configure
index 06c03cebd3..3217aa22cb 100755
--- a/configure
+++ b/configure
@@ -2826,6 +2826,18 @@ else
avx512f_opt="no"
fi
+#########################################
+# Disable out-of-line atomic operations.
+
+case "$cpu" in
+ aarch64)
+ write_c_skeleton;
+ if compile_prog "$CPU_CFLAGS -Werror -mno-outline-atomics" "" ; then
+ CPU_CFLAGS="-mno-outline-atomics $CPU_CFLAGS"
+ fi
+ ;;
+esac
+
########################################
# check if __[u]int128_t is usable.
--
2.34.1
next prev parent reply other threads:[~2022-02-15 17:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 17:00 [PATCH v2 0/8] buildsys: More fixes to use GCC on macOS Philippe Mathieu-Daudé via
2022-02-15 17:00 ` [PATCH v2 1/8] osdep: Avoid using Clang-specific __builtin_available() Philippe Mathieu-Daudé via
2022-02-15 17:01 ` [PATCH v2 2/8] osdep: Ignore 'unguarded-availability-new' warnings on macOS Catalina Philippe Mathieu-Daudé via
2022-02-16 2:36 ` Akihiko Odaki
2022-02-15 17:01 ` [PATCH v2 3/8] meson: Resolve the entitlement.sh script once for good Philippe Mathieu-Daudé via
2022-02-15 17:01 ` Philippe Mathieu-Daudé via [this message]
2022-02-16 2:41 ` [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64 Akihiko Odaki
2022-02-16 10:19 ` Richard Henderson
2022-02-16 15:08 ` Philippe Mathieu-Daudé via
2022-02-16 16:42 ` Akihiko Odaki
2022-02-16 17:18 ` Philippe Mathieu-Daudé via
2022-02-16 17:19 ` Peter Maydell
2022-02-18 1:46 ` Richard Henderson
2022-02-18 15:36 ` Paolo Bonzini
2022-03-06 22:21 ` Philippe Mathieu-Daudé
2022-02-18 15:42 ` Paolo Bonzini
2022-02-15 17:01 ` [PATCH v2 5/8] meson: Log QEMU_CXXFLAGS content in summary Philippe Mathieu-Daudé via
2022-02-15 17:01 ` [PATCH v2 6/8] configure: Pass filtered QEMU_OBJCFLAGS to meson Philippe Mathieu-Daudé via
2022-02-18 15:44 ` Paolo Bonzini
2022-02-15 17:01 ` [PATCH v2 7/8] audio: Rename coreaudio extension to use Objective-C compiler Philippe Mathieu-Daudé via
2022-02-15 17:01 ` [PATCH v2 8/8] ui/cocoa: Constify qkeycode translation arrays Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215170106.95848-5-f4bug@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=akihiko.odaki@gmail.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu_oss@crudebyte.com \
--cc=r.bolshakov@yadro.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).