Re: [RFC 4/8] ioregionfd: Introduce IORegionDFObject type

[Elena <elena.ufimtseva@oracle.com>]

On Mon, Feb 14, 2022 at 02:37:21PM +0000, Stefan Hajnoczi wrote:
> On Mon, Feb 07, 2022 at 11:22:18PM -0800, Elena Ufimtseva wrote:
> > Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> > ---
> >  meson.build                    |  15 ++-
> >  qapi/qom.json                  |  32 +++++-
> >  include/hw/remote/ioregionfd.h |  40 +++++++
> >  hw/remote/ioregionfd.c         | 196 +++++++++++++++++++++++++++++++++
> >  Kconfig.host                   |   3 +
> >  MAINTAINERS                    |   2 +
> >  hw/remote/Kconfig              |   4 +
> >  hw/remote/meson.build          |   1 +
> >  meson_options.txt              |   2 +
> >  scripts/meson-buildoptions.sh  |   3 +
> >  10 files changed, 294 insertions(+), 4 deletions(-)
> >  create mode 100644 include/hw/remote/ioregionfd.h
> >  create mode 100644 hw/remote/ioregionfd.c
> > 
> > diff --git a/meson.build b/meson.build
> > index 96de1a6ef9..6483e754bd 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -258,6 +258,17 @@ if targetos != 'linux' and get_option('multiprocess').enabled()
> >  endif
> >  multiprocess_allowed = targetos == 'linux' and not get_option('multiprocess').disabled()
> >  
> > +# TODO: drop this limitation
> 
> What is the reason for the limitation?
>

The idea is to limit use of this acceleration until the API is more
generic and does not need mutliprocess.

> > +if not multiprocess_allowed and not get_option('ioregionfd').disabled()
> > +  error('To enable ioregiofd support, enable mutliprocess option.')
> 
> s/ioregiofd/ioregionfd/
!

Thanks Stefan!