From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gautam Dawar <gdawar@xilinx.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Martin Petrus Hubertus Habets <martinh@xilinx.com>,
eperezma <eperezma@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Tanuj Murlidhar Kamde <tanujk@xilinx.com>,
Pablo Cascon <pabloc@xilinx.com>
Subject: Re: [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices
Date: Thu, 17 Feb 2022 03:32:45 -0500 [thread overview]
Message-ID: <20220217032859-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <BY5PR02MB698031726B87245DAD482982B1369@BY5PR02MB6980.namprd02.prod.outlook.com>
On Thu, Feb 17, 2022 at 08:27:14AM +0000, Gautam Dawar wrote:
> [GD>>] Yes , I agree a complete solution that will support the
> emulated virtio device with in_order rx/tx virtqueue functions will
> definitely be better but at the same time it will take considerable
> amount of time and effort. I also noticed that something similar
> (https://patchew.org/QEMU/1533833677-27512-1-git-send-email-i.maximets@samsung.com/)
> was proposed years ago which got dropped for similar reasons and it
> has been status quo since then.
Not applying a patch until it's complete is really the only
leverage maintainers have to push for complete patches.
Otherwise people keep adding half-baked code and hoping
that someone else does the rest of the work.
> So, unless we know that this work is
> already in progress & will be up-streamed soon and if you don’t see
> any side-effects of this patch, we can get it integrated first and
> then this can be reverted when the complete solution is available.
> This would help in benchmarking performance boosts achieved with
> IN_ORDER feature.
You can just carry the patch in private for benchmarking I guess?
--
MST
next prev parent reply other threads:[~2022-02-17 9:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 7:22 [PATCH 0/2] Allow VIRTIO_F_IN_ORDER negotiation with vhost-vdpa Gautam Dawar
2022-02-15 7:22 ` [PATCH 1/2] linux headers: update against Linux 5.17-rc4 Gautam Dawar
2022-02-17 7:17 ` Jason Wang
2022-02-17 9:06 ` Gautam Dawar
2022-02-15 7:22 ` [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices Gautam Dawar
2022-02-15 15:22 ` Eugenio Perez Martin
2022-02-17 7:16 ` Jason Wang
2022-02-17 8:27 ` Gautam Dawar
2022-02-17 8:32 ` Michael S. Tsirkin [this message]
2022-02-17 8:54 ` Eugenio Perez Martin
2022-02-17 7:32 ` Michael S. Tsirkin
2022-02-17 14:29 ` Stefano Garzarella
2022-02-18 10:24 ` Eugenio Perez Martin
2022-02-18 16:57 ` Stefano Garzarella
2022-02-18 10:22 ` Eugenio Perez Martin
2022-02-21 4:31 ` Jason Wang
2022-02-18 11:09 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217032859-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=martinh@xilinx.com \
--cc=pabloc@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=tanujk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).