From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55748C433EF for ; Fri, 18 Feb 2022 10:33:12 +0000 (UTC) Received: from localhost ([::1]:59180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nL0Zb-0008Hp-1o for qemu-devel@archiver.kernel.org; Fri, 18 Feb 2022 05:33:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL0YX-0007ae-EK for qemu-devel@nongnu.org; Fri, 18 Feb 2022 05:32:08 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL0YT-0004l5-94 for qemu-devel@nongnu.org; Fri, 18 Feb 2022 05:32:03 -0500 Received: from fraeml704-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4K0SYn2Hymz6801q; Fri, 18 Feb 2022 18:27:25 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml704-chm.china.huawei.com (10.206.15.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Fri, 18 Feb 2022 11:31:58 +0100 Received: from localhost (10.122.247.231) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Feb 2022 10:31:57 +0000 Date: Fri, 18 Feb 2022 10:31:56 +0000 To: Jonathan Cameron via CC: Jonathan Cameron , Marcel Apfelbaum , "Michael S . Tsirkin" , Subject: Re: [PATCH 1/2] pci-bridge/xio3130_upstream: Fix error handling Message-ID: <20220218103156.00002583@huawei.com> In-Reply-To: <20220218102303.7061-1-Jonathan.Cameron@huawei.com> References: <20220218102303.7061-1-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhreml722-chm.china.huawei.com (10.201.108.73) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Jonathan Cameron From: Jonathan Cameron via On Fri, 18 Feb 2022 10:23:02 +0000 Jonathan Cameron via wrote: > Goto label is incorrect so msi cleanup would not occur if there is > an error in the ssvid initialization. > > Signed-off-by: Jonathan Cameron +Cc: Linuxarm@huawei.com Turns out you get a weird result if you miss a space in your git send-email command. Apologies to Michael for scrambling his email address as a result! > --- > Noticed whilst working on equivalent CXL upstream switch port. > > hw/pci-bridge/xio3130_upstream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-bridge/xio3130_upstream.c b/hw/pci-bridge/xio3130_upstream.c > index 5cd3af4fbc..5ff46ef050 100644 > --- a/hw/pci-bridge/xio3130_upstream.c > +++ b/hw/pci-bridge/xio3130_upstream.c > @@ -75,7 +75,7 @@ static void xio3130_upstream_realize(PCIDevice *d, Error **errp) > XIO3130_SSVID_SVID, XIO3130_SSVID_SSID, > errp); > if (rc < 0) { > - goto err_bridge; > + goto err_msi; > } > > rc = pcie_cap_init(d, XIO3130_EXP_OFFSET, PCI_EXP_TYPE_UPSTREAM,