From: Halil Pasic <pasic@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Eric Farman" <farman@linux.ibm.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel@nongnu.org, "Halil Pasic" <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution
Date: Mon, 21 Feb 2022 13:26:27 +0100 [thread overview]
Message-ID: <20220221132627.78bbe5f2.pasic@linux.ibm.com> (raw)
In-Reply-To: <20220221101933.307525-1-thuth@redhat.com>
On Mon, 21 Feb 2022 11:19:33 +0100
Thomas Huth <thuth@redhat.com> wrote:
> QEMU's default screen resolution recently changed to 1280x800, so the
> resolution in the screen shot header changed of course, too.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Looks good!
Acked-by: Halil Pasic <pasic@linux.ibm.com>
> ---
> tests/avocado/machine_s390_ccw_virtio.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/avocado/machine_s390_ccw_virtio.py b/tests/avocado/machine_s390_ccw_virtio.py
> index bd03d7160b..438a6f4321 100644
> --- a/tests/avocado/machine_s390_ccw_virtio.py
> +++ b/tests/avocado/machine_s390_ccw_virtio.py
> @@ -248,7 +248,7 @@ def test_s390x_fedora(self):
> line = ppmfile.readline()
> self.assertEqual(line, b"P6\n")
> line = ppmfile.readline()
> - self.assertEqual(line, b"1024 768\n")
> + self.assertEqual(line, b"1280 800\n")
> line = ppmfile.readline()
> self.assertEqual(line, b"255\n")
> line = ppmfile.readline(256)
prev parent reply other threads:[~2022-02-21 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 10:19 [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution Thomas Huth
2022-02-21 10:58 ` Daniel P. Berrangé
2022-02-21 12:11 ` Philippe Mathieu-Daudé
2022-02-21 12:26 ` Halil Pasic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221132627.78bbe5f2.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=farman@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).