[PATCH 0/2] Minor fixes for the Python GDB plugins

[PATCH 0/2] Minor fixes for the Python GDB plugins

[David Edmondson]

In attempting to use the Python GDB plugins a couple of problems were
encountered.

David Edmondson (2):
  scripts/qemu-gdb/mtree.py: Int128 are decimal rather than hex
  scripts/qemu-gdb/timers.py: the 'last' attribute is no more

 scripts/qemugdb/mtree.py  | 2 +-
 scripts/qemugdb/timers.py | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.34.1

[PATCH 1/2] scripts/qemu-gdb/mtree.py: Int128 are decimal rather than hex

[David Edmondson]

When parsing QEMU's native Int128 type, do not attempt to convert from
hexadecimal.

Fixes: 8037fa55ac ("scripts/qemugdb/mtree.py: fix up mtree dump")
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
---
 scripts/qemugdb/mtree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/qemugdb/mtree.py b/scripts/qemugdb/mtree.py
index 8fe42c3c12..c1557d44fa 100644
--- a/scripts/qemugdb/mtree.py
+++ b/scripts/qemugdb/mtree.py
@@ -25,7 +25,7 @@ def int128(p):
     if p.type.code == gdb.TYPE_CODE_STRUCT:
         return int(p['lo']) + (int(p['hi']) << 64)
     else:
-        return int(("%s" % p), 16)
+        return int("%s" % p)
 
 class MtreeCommand(gdb.Command):
     '''Display the memory tree hierarchy'''
-- 
2.34.1

[PATCH 2/2] scripts/qemu-gdb/timers.py: the 'last' attribute is no more

[David Edmondson]

The 'last' member of QEMUClock was removed some time ago, but the
python gdb helper did not notice.

Fixes: 3c2d4c8aa6 ("timer: last, remove last bits of last")
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
---
 scripts/qemugdb/timers.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/qemugdb/timers.py b/scripts/qemugdb/timers.py
index 46537b27cf..0538677288 100644
--- a/scripts/qemugdb/timers.py
+++ b/scripts/qemugdb/timers.py
@@ -37,10 +37,9 @@ def dump_timers(self, timer):
 
     def process_timerlist(self, tlist, ttype):
         gdb.write("Processing %s timers\n" % (ttype))
-        gdb.write("  clock %s is enabled:%s, last:%s\n" % (
+        gdb.write("  clock %s is enabled:%s\n" % (
             tlist['clock']['type'],
-            tlist['clock']['enabled'],
-            tlist['clock']['last']))
+            tlist['clock']['enabled']))
         if int(tlist['active_timers']) > 0:
             self.dump_timers(tlist['active_timers'])
 
-- 
2.34.1

Re: [PATCH 2/2] scripts/qemu-gdb/timers.py: the 'last' attribute is no more

[Philippe Mathieu-Daudé]

On 21/2/22 17:49, David Edmondson wrote:
> The 'last' member of QEMUClock was removed some time ago, but the
> python gdb helper did not notice.
> 
> Fixes: 3c2d4c8aa6 ("timer: last, remove last bits of last")
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
>   scripts/qemugdb/timers.py | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Ouch, 2+ years.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH 1/2] scripts/qemu-gdb/mtree.py: Int128 are decimal rather than hex

[David Edmondson]

Ping?

On Monday, 2022-02-21 at 16:49:47 GMT, David Edmondson wrote:

> When parsing QEMU's native Int128 type, do not attempt to convert from
> hexadecimal.
>
> Fixes: 8037fa55ac ("scripts/qemugdb/mtree.py: fix up mtree dump")
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
>  scripts/qemugdb/mtree.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemugdb/mtree.py b/scripts/qemugdb/mtree.py
> index 8fe42c3c12..c1557d44fa 100644
> --- a/scripts/qemugdb/mtree.py
> +++ b/scripts/qemugdb/mtree.py
> @@ -25,7 +25,7 @@ def int128(p):
>      if p.type.code == gdb.TYPE_CODE_STRUCT:
>          return int(p['lo']) + (int(p['hi']) << 64)
>      else:
> -        return int(("%s" % p), 16)
> +        return int("%s" % p)
>
>  class MtreeCommand(gdb.Command):
>      '''Display the memory tree hierarchy'''

dme.
-- 
The band is just fantastic, that is really what I think.