From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>
Subject: [PATCH v2 2/3] qapi: Document some missing details of RTC_CHANGE event
Date: Mon, 21 Feb 2022 19:21:22 +0000 [thread overview]
Message-ID: <20220221192123.749970-3-peter.maydell@linaro.org> (raw)
In-Reply-To: <20220221192123.749970-1-peter.maydell@linaro.org>
The RTC_CHANGE event's documentation is missing some details:
* the offset argument is in units of seconds
* it isn't guaranteed that the RTC will implement the event
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
v1->v2: add the "RTC might not implement this" note
---
qapi/misc.json | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index 7a70eaa3ffc..0ab235e41f7 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -533,10 +533,12 @@
#
# Emitted when the guest changes the RTC time.
#
-# @offset: offset between base RTC clock (as specified by -rtc base), and
-# new RTC clock value
+# @offset: offset in seconds between base RTC clock (as specified
+# by -rtc base), and new RTC clock value
#
# Note: This event is rate-limited.
+# It is not guaranteed that the RTC in the system implements
+# this event, or even that the system has an RTC at all.
#
# Since: 0.13
#
--
2.25.1
next prev parent reply other threads:[~2022-02-21 19:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 19:21 [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema Peter Maydell
2022-02-21 19:21 ` [PATCH v2 1/3] " Peter Maydell
2022-02-21 19:27 ` Philippe Mathieu-Daudé
2022-02-21 19:21 ` Peter Maydell [this message]
2022-02-21 19:28 ` [PATCH v2 2/3] qapi: Document some missing details of RTC_CHANGE event Philippe Mathieu-Daudé
2022-02-22 11:22 ` Markus Armbruster
2022-02-21 19:21 ` [PATCH v2 3/3] hw/rtc: Compile pl031 once-only Peter Maydell
2022-02-21 19:28 ` Philippe Mathieu-Daudé
2022-02-21 20:11 ` [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema Eric Auger
2022-02-22 12:02 ` [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path Markus Armbruster
2022-02-22 12:56 ` Philippe Mathieu-Daudé
2022-02-22 13:06 ` Peter Maydell
2022-02-22 15:47 ` Philippe Mathieu-Daudé
2022-02-23 18:00 ` Cédric Le Goater
2022-02-22 15:04 ` Markus Armbruster
2022-02-22 15:47 ` Philippe Mathieu-Daudé
2022-02-23 13:46 ` Markus Armbruster
2022-02-25 8:38 ` [PATCH v2 0/3] qapi: Move RTC_CHANGE back out of target schema Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221192123.749970-3-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).