qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <laurent@vivier.eu>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [PULL 1/7] configure: Disable capstone and slirp in the --without-default-features mode
Date: Tue, 22 Feb 2022 17:16:18 +0100	[thread overview]
Message-ID: <20220222161624.382218-2-laurent@vivier.eu> (raw)
In-Reply-To: <20220222161624.382218-1-laurent@vivier.eu>

From: Thomas Huth <thuth@redhat.com>

For the users, it looks a little bit weird that capstone and slirp are
not disabled automatically if they run the configure script with the
"--without-default-features" option, so let's do that now.
Note: fdt is *not* changed accordingly since this affects the targets
that we can build, so disabling fdt automatically here might have
unexpected side-effects for the users.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20220221090647.150184-1-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 configure | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 3a29eff5cc16..36d10d95bba8 100755
--- a/configure
+++ b/configure
@@ -361,9 +361,14 @@ slirp_smbd="$default_feature"
 # are included in the automatically generated help message)
 
 # 1. Track which submodules are needed
-capstone="auto"
+if test "$default_feature" = no ; then
+  capstone="disabled"
+  slirp="disabled"
+else
+  capstone="auto"
+  slirp="auto"
+fi
 fdt="auto"
-slirp="auto"
 
 # 2. Support --with/--without option
 default_devices="true"
-- 
2.35.1



  reply	other threads:[~2022-02-22 16:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 16:16 [PULL 0/7] Trivial branch for 7.0 patches Laurent Vivier
2022-02-22 16:16 ` Laurent Vivier [this message]
2022-02-22 16:16 ` [PULL 2/7] target/avr: Correct AVRCPUClass docstring Laurent Vivier
2022-02-22 16:16 ` [PULL 3/7] target/rx: Remove unused ENV_OFFSET definition Laurent Vivier
2022-02-22 16:16 ` [PULL 4/7] hw/nvram: use at24 macro Laurent Vivier
2022-02-22 16:16 ` [PULL 5/7] qemu-options: fix incorrect description for '-drive index=' Laurent Vivier
2022-02-22 16:16 ` [PULL 6/7] vdpa: Make ncs autofree Laurent Vivier
2022-02-22 16:16 ` [PULL 7/7] hid: Implement support for side and extra buttons Laurent Vivier
2022-02-23  9:24 ` [PULL 0/7] Trivial branch for 7.0 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222161624.382218-2-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).