qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Bernhard Beschow <shentey@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH 03/22] hw/input/pckbd: QOM'ify IRQ numbers
Date: Tue, 22 Feb 2022 18:38:00 +0100	[thread overview]
Message-ID: <20220222173819.76568-4-shentey@gmail.com> (raw)
In-Reply-To: <20220222173819.76568-1-shentey@gmail.com>

Exposing the IRQ numbers as a QOM properties not only allows them to be
configurable but also to be printed by standard QOM mechanisms. This allows
isabus_dev_print() to be retired eventually.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/input/pckbd.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
index baba62f357..e56bee87d2 100644
--- a/hw/input/pckbd.c
+++ b/hw/input/pckbd.c
@@ -671,6 +671,8 @@ struct ISAKBDState {
     KBDState kbd;
     bool kbd_throttle;
     MemoryRegion io[2];
+    uint32_t kbd_irq;
+    uint32_t mouse_irq;
 };
 
 void i8042_isa_mouse_fake_event(ISAKBDState *isa)
@@ -734,8 +736,8 @@ static void i8042_realizefn(DeviceState *dev, Error **errp)
     ISAKBDState *isa_s = I8042(dev);
     KBDState *s = &isa_s->kbd;
 
-    isa_init_irq(isadev, &s->irq_kbd, 1);
-    isa_init_irq(isadev, &s->irq_mouse, 12);
+    isa_init_irq(isadev, &s->irq_kbd, isa_s->kbd_irq);
+    isa_init_irq(isadev, &s->irq_mouse, isa_s->mouse_irq);
 
     isa_register_ioport(isadev, isa_s->io + 0, 0x60);
     isa_register_ioport(isadev, isa_s->io + 1, 0x64);
@@ -754,6 +756,7 @@ static void i8042_realizefn(DeviceState *dev, Error **errp)
 
 static void i8042_build_aml(ISADevice *isadev, Aml *scope)
 {
+    ISAKBDState *isa_s = I8042(isadev);
     Aml *kbd;
     Aml *mou;
     Aml *crs;
@@ -761,7 +764,7 @@ static void i8042_build_aml(ISADevice *isadev, Aml *scope)
     crs = aml_resource_template();
     aml_append(crs, aml_io(AML_DECODE16, 0x0060, 0x0060, 0x01, 0x01));
     aml_append(crs, aml_io(AML_DECODE16, 0x0064, 0x0064, 0x01, 0x01));
-    aml_append(crs, aml_irq_no_flags(1));
+    aml_append(crs, aml_irq_no_flags(isa_s->kbd_irq));
 
     kbd = aml_device("KBD");
     aml_append(kbd, aml_name_decl("_HID", aml_eisaid("PNP0303")));
@@ -769,7 +772,7 @@ static void i8042_build_aml(ISADevice *isadev, Aml *scope)
     aml_append(kbd, aml_name_decl("_CRS", crs));
 
     crs = aml_resource_template();
-    aml_append(crs, aml_irq_no_flags(12));
+    aml_append(crs, aml_irq_no_flags(isa_s->mouse_irq));
 
     mou = aml_device("MOU");
     aml_append(mou, aml_name_decl("_HID", aml_eisaid("PNP0F13")));
@@ -783,6 +786,8 @@ static void i8042_build_aml(ISADevice *isadev, Aml *scope)
 static Property i8042_properties[] = {
     DEFINE_PROP_BOOL("extended-state", ISAKBDState, kbd.extended_state, true),
     DEFINE_PROP_BOOL("kbd-throttle", ISAKBDState, kbd_throttle, false),
+    DEFINE_PROP_UINT32("kbd-irq", ISAKBDState, kbd_irq, 1),
+    DEFINE_PROP_UINT32("mouse-irq", ISAKBDState, mouse_irq, 12),
     DEFINE_PROP_END_OF_LIST(),
 };
 
-- 
2.35.1



  parent reply	other threads:[~2022-02-22 17:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 17:37 [PATCH 00/22] isa: Resolve unneeded IRQ attributes from ISADevice Bernhard Beschow
2022-02-22 17:37 ` [PATCH 01/22] hw/rtc/mc146818rtc: QOM'ify IRQ number Bernhard Beschow
2022-02-22 17:37 ` [PATCH 02/22] hw/rtc/m48t59-isa: " Bernhard Beschow
2022-02-22 17:47   ` Peter Maydell
2022-02-22 17:54     ` Bernhard Beschow
2022-02-22 17:38 ` Bernhard Beschow [this message]
2022-02-22 17:38 ` [PATCH 04/22] hw/isa/isa-bus: Remove isabus_dev_print() Bernhard Beschow
2022-02-22 17:38 ` [PATCH 05/22] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property Bernhard Beschow
2022-02-22 17:38 ` [PATCH 06/22] isa: Drop unused attributes from ISADevice Bernhard Beschow
2022-02-22 17:38 ` [PATCH 07/22] hw/audio/cs4231a: Disuse isa_init_irq() Bernhard Beschow
2022-02-22 17:38 ` [PATCH 08/22] hw/audio/gus: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 09/22] hw/audio/sb16: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 10/22] hw/block/fdc-isa: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 11/22] hw/char/parallel: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 12/22] hw/char/serial-isa: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 13/22] hw/ide/isa: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 14/22] hw/input/pckbd: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 15/22] hw/ipmi/isa_ipmi_bt: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 16/22] hw/ipmi/isa_ipmi_kcs: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 17/22] hw/isa/piix4: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 18/22] hw/net/ne2000-isa: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 19/22] hw/rtc/m48t59-isa: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 20/22] hw/tpm/tpm_tis_isa: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 21/22] hw/isa/isa-bus: " Bernhard Beschow
2022-02-22 17:38 ` [PATCH 22/22] isa: Remove unused isa_init_irq() Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222173819.76568-4-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).