From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: Bernhard Beschow <shentey@gmail.com>
Subject: [PATCH v2 06/22] isa: Drop unused attributes from ISADevice
Date: Tue, 22 Feb 2022 20:34:30 +0100 [thread overview]
Message-ID: <20220222193446.156717-7-shentey@gmail.com> (raw)
In-Reply-To: <20220222193446.156717-1-shentey@gmail.com>
Now that the last users of ISADevice::isairq[] have been resolved during the
previous commits, it can be removed for good.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/isa/isa-bus.c | 13 -------------
include/hw/isa/isa.h | 2 --
2 files changed, 15 deletions(-)
diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
index af5add6a26..c64a14120b 100644
--- a/hw/isa/isa-bus.c
+++ b/hw/isa/isa-bus.c
@@ -87,11 +87,7 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq)
void isa_init_irq(ISADevice *dev, qemu_irq *p, unsigned isairq)
{
- assert(dev->nirqs < ARRAY_SIZE(dev->isairq));
- assert(isairq < ISA_NUM_IRQS);
- dev->isairq[dev->nirqs] = isairq;
*p = isa_get_irq(dev, isairq);
- dev->nirqs++;
}
void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq)
@@ -150,14 +146,6 @@ int isa_register_portio_list(ISADevice *dev,
return 0;
}
-static void isa_device_init(Object *obj)
-{
- ISADevice *dev = ISA_DEVICE(obj);
-
- dev->isairq[0] = -1;
- dev->isairq[1] = -1;
-}
-
ISADevice *isa_new(const char *name)
{
return ISA_DEVICE(qdev_new(name));
@@ -244,7 +232,6 @@ static const TypeInfo isa_device_type_info = {
.name = TYPE_ISA_DEVICE,
.parent = TYPE_DEVICE,
.instance_size = sizeof(ISADevice),
- .instance_init = isa_device_init,
.abstract = true,
.class_size = sizeof(ISADeviceClass),
.class_init = isa_device_class_init,
diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h
index d4417b34b6..d80cab5b79 100644
--- a/include/hw/isa/isa.h
+++ b/include/hw/isa/isa.h
@@ -83,8 +83,6 @@ struct ISADevice {
DeviceState parent_obj;
/*< public >*/
- int8_t isairq[2]; /* -1 = unassigned */
- int nirqs;
int ioport_id;
};
--
2.35.1
next prev parent reply other threads:[~2022-02-22 19:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 19:34 [PATCH v2 00/22] isa: Resolve unneeded IRQ attributes from ISADevice Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 01/22] hw/rtc/mc146818rtc: QOM'ify IRQ number Bernhard Beschow
2022-02-27 22:10 ` Philippe Mathieu-Daudé
2022-02-22 19:34 ` [PATCH v2 02/22] hw/rtc/m48t59-isa: " Bernhard Beschow
2022-02-27 22:13 ` Philippe Mathieu-Daudé
2022-02-22 19:34 ` [PATCH v2 03/22] hw/input/pckbd: QOM'ify IRQ numbers Bernhard Beschow
2022-02-27 22:14 ` Philippe Mathieu-Daudé
2022-02-22 19:34 ` [PATCH v2 04/22] hw/isa/isa-bus: Remove isabus_dev_print() Bernhard Beschow
2022-02-27 22:39 ` Philippe Mathieu-Daudé
2022-02-22 19:34 ` [PATCH v2 05/22] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property Bernhard Beschow
2022-02-26 11:24 ` Cédric Le Goater
2022-02-26 11:27 ` BB
2022-02-27 22:17 ` Philippe Mathieu-Daudé
2022-03-01 8:31 ` Cédric Le Goater
2022-02-22 19:34 ` Bernhard Beschow [this message]
2022-02-27 22:19 ` [PATCH v2 06/22] isa: Drop unused attributes from ISADevice Philippe Mathieu-Daudé
2022-02-22 19:34 ` [PATCH v2 07/22] hw/audio/cs4231a: Disuse isa_init_irq() Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 08/22] hw/audio/gus: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 09/22] hw/audio/sb16: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 10/22] hw/block/fdc-isa: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 11/22] hw/char/parallel: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 12/22] hw/char/serial-isa: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 13/22] hw/ide/isa: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 14/22] hw/input/pckbd: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 15/22] hw/ipmi/isa_ipmi_bt: " Bernhard Beschow
2022-02-26 20:16 ` Corey Minyard
2022-02-22 19:34 ` [PATCH v2 16/22] hw/ipmi/isa_ipmi_kcs: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 17/22] hw/isa/piix4: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 18/22] hw/net/ne2000-isa: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 19/22] hw/rtc/m48t59-isa: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 20/22] hw/tpm/tpm_tis_isa: " Bernhard Beschow
2022-02-22 19:50 ` Stefan Berger
2022-02-22 19:34 ` [PATCH v2 21/22] hw/isa/isa-bus: " Bernhard Beschow
2022-02-22 19:34 ` [PATCH v2 22/22] isa: Remove unused isa_init_irq() Bernhard Beschow
2022-02-27 22:27 ` Philippe Mathieu-Daudé
2022-02-27 22:40 ` [PATCH v2 00/22] isa: Resolve unneeded IRQ attributes from ISADevice Philippe Mathieu-Daudé
2022-03-01 12:04 ` Philippe Mathieu-Daudé
2022-03-01 22:03 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222193446.156717-7-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).