* [PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle'
@ 2022-02-23 12:31 Thomas Huth
2022-02-24 16:41 ` Hanna Reitz
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2022-02-23 12:31 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, Hanna Reitz, qemu-devel
iotest 040 already has some checks for the availability of the 'throttle'
driver, but some new code has been added in the course of time that
depends on 'throttle' but does not check for its availability. Add
a check to the TestCommitWithFilters class so that this iotest now
also passes again if 'throttle' has not been enabled in the QEMU
binaries.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/040 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 6af5ab9e76..0e1cfd7e49 100755
--- a/tests/qemu-iotests/040
+++ b/tests/qemu-iotests/040
@@ -744,6 +744,7 @@ class TestCommitWithFilters(iotests.QMPTestCase):
pattern_file)
self.assertFalse('Pattern verification failed' in result)
+ @iotests.skip_if_unsupported(['throttle'])
def setUp(self):
qemu_img('create', '-f', iotests.imgfmt, self.img0, '64M')
qemu_img('create', '-f', iotests.imgfmt, self.img1, '64M')
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle'
2022-02-23 12:31 [PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle' Thomas Huth
@ 2022-02-24 16:41 ` Hanna Reitz
0 siblings, 0 replies; 2+ messages in thread
From: Hanna Reitz @ 2022-02-24 16:41 UTC (permalink / raw)
To: Thomas Huth, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 23.02.22 13:31, Thomas Huth wrote:
> iotest 040 already has some checks for the availability of the 'throttle'
> driver, but some new code has been added in the course of time that
> depends on 'throttle' but does not check for its availability. Add
> a check to the TestCommitWithFilters class so that this iotest now
> also passes again if 'throttle' has not been enabled in the QEMU
> binaries.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/040 | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https://gitlab.com/hreitz/qemu/-/commits/block
Hanna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-24 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-23 12:31 [PATCH] tests/qemu-iotests/040: Skip TestCommitWithFilters without 'throttle' Thomas Huth
2022-02-24 16:41 ` Hanna Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).