From: Ani Sinha <ani@anisinha.ca>
To: qemu-devel@nongnu.org, mst@redhat.com,
Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>
Cc: Eric DeVolder <eric.devolder@oracle.com>
Subject: [PATCH 4/7] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro
Date: Wed, 23 Feb 2022 20:03:19 +0530 [thread overview]
Message-ID: <20220223143322.927136-5-ani@anisinha.ca> (raw)
In-Reply-To: <20220223143322.927136-1-ani@anisinha.ca>
This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added
as a part of the ERST implementation seems to be unused. Remove it.
CC: Eric DeVolder <eric.devolder@oracle.com>
Reviewed-by: Eric DeVolder <eric.devolder@oracle.com>
Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
hw/acpi/erst.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
index c0a23cf467..de509c2b48 100644
--- a/hw/acpi/erst.c
+++ b/hw/acpi/erst.c
@@ -80,11 +80,6 @@
#define UEFI_CPER_RECORD_MIN_SIZE 128U
#define UEFI_CPER_RECORD_LENGTH_OFFSET 20U
#define UEFI_CPER_RECORD_ID_OFFSET 96U
-#define IS_UEFI_CPER_RECORD(ptr) \
- (((ptr)[0] == 'C') && \
- ((ptr)[1] == 'P') && \
- ((ptr)[2] == 'E') && \
- ((ptr)[3] == 'R'))
/*
* NOTE that when accessing CPER fields within a record, memcpy()
--
2.25.1
next prev parent reply other threads:[~2022-02-23 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 14:33 [PATCH 0/7] Queued patches for the next pull request Ani Sinha
2022-02-23 14:33 ` [PATCH 1/7] ACPI ERST: specification for ERST support Ani Sinha
2022-02-23 14:33 ` [PATCH 2/7] MAINTAINERS: no need to add my name explicitly as a reviewer for VIOT tables Ani Sinha
2022-02-23 14:33 ` [PATCH 3/7] docs/acpi/erst: add device id for ACPI ERST device in pci-ids.txt Ani Sinha
2022-02-23 14:33 ` Ani Sinha [this message]
2022-02-23 14:33 ` [PATCH 5/7] hw/smbios: code cleanup - use macro definitions for table header handles Ani Sinha
2022-02-24 7:26 ` Philippe Mathieu-Daudé
2022-02-23 14:33 ` [PATCH 6/7] hw/smbios: fix overlapping table handle numbers with large memory vms Ani Sinha
2022-02-23 14:33 ` [PATCH 7/7] hw/smbios: add assertion to ensure handles of tables 19 and 32 do not collide Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223143322.927136-5-ani@anisinha.ca \
--to=ani@anisinha.ca \
--cc=eric.devolder@oracle.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).