* [PATCH] qapi: fix mistake in example command illustration
@ 2022-02-23 18:04 Daniel P. Berrangé
2022-02-23 18:37 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Daniel P. Berrangé @ 2022-02-23 18:04 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P. Berrangé, Eric Blake, Markus Armbruster,
Dr. David Alan Gilbert, Juan Quintela
The snapshot-load/save/delete commands illustrated their usage, but
mistakenly used 'data' rather than 'arguments' as the field name.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
qapi/migration.json | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 5975a0e104..1c6296897d 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1888,7 +1888,7 @@
# Example:
#
# -> { "execute": "snapshot-save",
-# "data": {
+# "arguments": {
# "job-id": "snapsave0",
# "tag": "my-snap",
# "vmstate": "disk0",
@@ -1949,7 +1949,7 @@
# Example:
#
# -> { "execute": "snapshot-load",
-# "data": {
+# "arguments": {
# "job-id": "snapload0",
# "tag": "my-snap",
# "vmstate": "disk0",
@@ -2002,7 +2002,7 @@
# Example:
#
# -> { "execute": "snapshot-delete",
-# "data": {
+# "arguments": {
# "job-id": "snapdelete0",
# "tag": "my-snap",
# "devices": ["disk0", "disk1"]
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qapi: fix mistake in example command illustration
2022-02-23 18:04 [PATCH] qapi: fix mistake in example command illustration Daniel P. Berrangé
@ 2022-02-23 18:37 ` Dr. David Alan Gilbert
2022-02-24 6:39 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2022-02-23 18:37 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: Juan Quintela, Eric Blake, qemu-devel, Markus Armbruster
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> The snapshot-load/save/delete commands illustrated their usage, but
> mistakenly used 'data' rather than 'arguments' as the field name.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Fabian Holler's patch from yesterday beat you to it slightly;
I think Markus has it queued.
(20220222170116.63105-1-fabian.holler@simplesurance.de )
> ---
> qapi/migration.json | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 5975a0e104..1c6296897d 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1888,7 +1888,7 @@
> # Example:
> #
> # -> { "execute": "snapshot-save",
> -# "data": {
> +# "arguments": {
> # "job-id": "snapsave0",
> # "tag": "my-snap",
> # "vmstate": "disk0",
> @@ -1949,7 +1949,7 @@
> # Example:
> #
> # -> { "execute": "snapshot-load",
> -# "data": {
> +# "arguments": {
> # "job-id": "snapload0",
> # "tag": "my-snap",
> # "vmstate": "disk0",
> @@ -2002,7 +2002,7 @@
> # Example:
> #
> # -> { "execute": "snapshot-delete",
> -# "data": {
> +# "arguments": {
> # "job-id": "snapdelete0",
> # "tag": "my-snap",
> # "devices": ["disk0", "disk1"]
> --
> 2.34.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qapi: fix mistake in example command illustration
2022-02-23 18:37 ` Dr. David Alan Gilbert
@ 2022-02-24 6:39 ` Markus Armbruster
0 siblings, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2022-02-24 6:39 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: Eric Blake, Daniel P. Berrangé, qemu-devel, Juan Quintela
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Daniel P. Berrangé (berrange@redhat.com) wrote:
>> The snapshot-load/save/delete commands illustrated their usage, but
>> mistakenly used 'data' rather than 'arguments' as the field name.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Fabian Holler's patch from yesterday beat you to it slightly;
> I think Markus has it queued.
Correct. Thanks anyway!
> (20220222170116.63105-1-fabian.holler@simplesurance.de )
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-24 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-23 18:04 [PATCH] qapi: fix mistake in example command illustration Daniel P. Berrangé
2022-02-23 18:37 ` Dr. David Alan Gilbert
2022-02-24 6:39 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).