[PATCH] hw/intc/armv7m_nvic: Fix typo in comment

[PATCH] hw/intc/armv7m_nvic: Fix typo in comment

[Evgeny Ermakov]

Signed-off-by: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
---
 hw/intc/armv7m_nvic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
index 13df002ce4..a08a0fdc50 100644
--- a/hw/intc/armv7m_nvic.c
+++ b/hw/intc/armv7m_nvic.c
@@ -97,7 +97,7 @@ static int nvic_pending_prio(NVICState *s)
  * this is only different in the obscure corner case where guest
  * code has manually deactivated an exception and is about
  * to fail an exception-return integrity check. The definition
- * above is the one from the v8M ARM ARM and is also in line
+ * above is the one from the v8M ARM and is also in line
  * with the behaviour documented for the Cortex-M3.
  */
 static bool nvic_rettobase(NVICState *s)
-- 
2.35.1

Re: [PATCH] hw/intc/armv7m_nvic: Fix typo in comment

[Peter Maydell]

On Thu, 24 Feb 2022 at 12:22, Evgeny Ermakov <evgeny.v.ermakov@gmail.com> wrote:
>
> Signed-off-by: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
> ---
>  hw/intc/armv7m_nvic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index 13df002ce4..a08a0fdc50 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -97,7 +97,7 @@ static int nvic_pending_prio(NVICState *s)
>   * this is only different in the obscure corner case where guest
>   * code has manually deactivated an exception and is about
>   * to fail an exception-return integrity check. The definition
> - * above is the one from the v8M ARM ARM and is also in line
> + * above is the one from the v8M ARM and is also in line
>   * with the behaviour documented for the Cortex-M3.
>   */

This is not a typo. The "ARM ARM" (or "Arm ARM" these days if
you want to follow the official corporate name capitalization)
is the standard abbreviated way to refer to the
Arm Architecture Reference Manual. "git grep -i 'arm arm'"
finds over 50 uses of it in various comments.

thanks
-- PMM

Re: [PATCH] hw/intc/armv7m_nvic: Fix typo in comment

[Evgeny Ermakov]

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

Ah, indeed.

Sorry for having bothered you.


On Thu, 24 Feb 2022, 23:46 Peter Maydell, <peter.maydell@linaro.org> wrote:

> On Thu, 24 Feb 2022 at 12:22, Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
> wrote:
> >
> > Signed-off-by: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
> > ---
> >  hw/intc/armv7m_nvic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> > index 13df002ce4..a08a0fdc50 100644
> > --- a/hw/intc/armv7m_nvic.c
> > +++ b/hw/intc/armv7m_nvic.c
> > @@ -97,7 +97,7 @@ static int nvic_pending_prio(NVICState *s)
> >   * this is only different in the obscure corner case where guest
> >   * code has manually deactivated an exception and is about
> >   * to fail an exception-return integrity check. The definition
> > - * above is the one from the v8M ARM ARM and is also in line
> > + * above is the one from the v8M ARM and is also in line
> >   * with the behaviour documented for the Cortex-M3.
> >   */
>
> This is not a typo. The "ARM ARM" (or "Arm ARM" these days if
> you want to follow the official corporate name capitalization)
> is the standard abbreviated way to refer to the
> Arm Architecture Reference Manual. "git grep -i 'arm arm'"
> finds over 50 uses of it in various comments.
>
> thanks
> -- PMM
>

[-- Attachment #2: Type: text/html, Size: 2057 bytes --]